From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E61911F5CB; Wed, 25 Sep 2024 21:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1727301236; bh=qoF+91X2a134VeZcqy7jXVBOvUSUNxvzAsuHv/8ISGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y70k497UrxplLu7s2RzRkrlp4+p+Kd54m15KbHiS4B0wq6n/D52RAh7D0BQY3mDjW JVrc16R7XDZS4Pgq+xNELB+Vk/KuxxQMHlFkahlQ5qyo2KauRqpTcIpEVfXMexfM1T Put7yRb6selNGItVJB/cAScJycFwU75XHQK93/+w= Date: Wed, 25 Sep 2024 21:50:16 +0000 From: Eric Wong To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Cc: meta@public-inbox.org Subject: Re: [PATCH] viewvcs: fix b= generation in $REPO/tree/ listing Message-ID: <20240925215016.M975010@dcvr> References: <20240924183548.509216-1-e@80x24.org> <20240925062859Z.1065885456-stepnem@smrk.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240925062859Z.1065885456-stepnem@smrk.net> List-Id: Štěpán Němec wrote: > On Tue, 24 Sep 2024 18:35:48 +0000 > Eric Wong wrote: > > > Queries such as `b=contrib/cssREADME' are incorrect despite > > having the actual blob OID for the given file. Add a trailing > > "slash" missing here? Thnks, pushed as commit d39bc7f648dc59abe1f4b7eb086e78af74fe25fc Queries such as `b=contrib/cssREADME' are incorrect despite having the actual blob OID for the given file. Add a trailing slash for files in a project subdirectory in those cases as we do for cases we don't have a known path name. While we're in the area, avoid needless shadowing of the `$t' var and add a comment to describe its contents.