[PATCH] viewvcs: fix b= generation in $REPO/tree/ listing

[PATCH] viewvcs: fix b= generation in $REPO/tree/ listing

[Eric Wong]

Queries such as `b=contrib/cssREADME' are incorrect despite
having the actual blob OID for the given file.  Add a trailing
for files in a project subdirectory in those cases as we do
for cases we don't have a known path name.

While we're in the area, avoid needless shadowing of the `$t'
var and add a comment to describe its contents.
---
 lib/PublicInbox/ViewVCS.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 3e604901..e556a0e2 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -409,8 +409,9 @@ sub show_tree_result ($$) {
 	my $upfx = $ctx->{-upfx} //= '../../';
 	if (defined $pfx) {
 		$pfx =~ s!/+\z!!s;
-		if (my $t = $ctx->{-obj}) {
-			my $t = ascii_html($t);
+		if (my $t = $ctx->{-obj}) { # $t eq "$tip:$path"
+			$t = ascii_html($t);
+			$pfx .= '/' if $pfx ne '';
 			$$bref .= <<EOM
 \n\$ git ls-tree -l $t	# shows similar output on the CLI
 EOM

Re: [PATCH] viewvcs: fix b= generation in $REPO/tree/ listing

[Štěpán Němec]

On Tue, 24 Sep 2024 18:35:48 +0000
Eric Wong wrote:

> Queries such as `b=contrib/cssREADME' are incorrect despite
> having the actual blob OID for the given file.  Add a trailing

"slash" missing here?

> for files in a project subdirectory in those cases as we do
> for cases we don't have a known path name.

[...]

Thanks,

  Štěpán

Re: [PATCH] viewvcs: fix b= generation in $REPO/tree/ listing

[Eric Wong]

Štěpán Němec <stepnem@smrk.net> wrote:
> On Tue, 24 Sep 2024 18:35:48 +0000
> Eric Wong wrote:
> 
> > Queries such as `b=contrib/cssREADME' are incorrect despite
> > having the actual blob OID for the given file.  Add a trailing
> 
> "slash" missing here?

Thnks, pushed as commit d39bc7f648dc59abe1f4b7eb086e78af74fe25fc

    Queries such as `b=contrib/cssREADME' are incorrect despite
    having the actual blob OID for the given file.  Add a trailing
    slash for files in a project subdirectory in those cases as we
    do for cases we don't have a known path name.

    While we're in the area, avoid needless shadowing of the `$t'
    var and add a comment to describe its contents.