From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id CD1FF1F5CB
	for <meta@public-inbox.org>; Mon, 16 Sep 2024 09:57:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1726480633;
	bh=pcdDjAncU9ceHies5n6c3sRLtuB7RSMXICfCUmHmjAk=;
	h=From:To:Subject:Date:From;
	b=NlPA5QEIe/UvXl/bS9qKDn+9UALRYXBSTWotPbIvh1uKBQfLxh5MqqTzAO5mrbZbv
	 PHu1fAuB9l8+HuAP2BHPBWlr5Jx5A8TCEu4DFN0WyblCkIH+UtbxTQg/cWBRfmrgDs
	 kbh3CI2+OvqXY6ADuBQ/kPTnFC3O2nl5dQhcM6+o=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/feed: fix uninitialized variable warnings
Date: Mon, 16 Sep 2024 09:53:59 +0000
Message-ID: <20240916095359.96854-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

These warnings only happened under test conditions and never
when running under any PSGI servers.  In retrospect, t/feed.t is
likely redundant nowadays and ought to be folded into existing
PSGI tests so we don't have to consider setup problems like
these.

Fixes: bbe582cdfa429 ("view: fix addr2urlmap with Plack::Builder::mount")
---
 t/feed.t | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/t/feed.t b/t/feed.t
index cc5ae277..8e80b531 100644
--- a/t/feed.t
+++ b/t/feed.t
@@ -1,5 +1,5 @@
 #!perl -w
-# Copyright (C) 2014-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use v5.10.1;
@@ -10,17 +10,6 @@ use PublicInbox::Inbox;
 my $have_xml_treepp = eval { require XML::TreePP; 1 };
 my ($tmpdir, $for_destroy) = tmpdir();
 
-sub string_feed {
-	my $res = PublicInbox::Feed::generate($_[0]);
-	my $body = $res->[2];
-	my $str = '';
-	while (defined(my $chunk = $body->getline)) {
-		$str .= $chunk;
-	}
-	$body->close;
-	$str;
-}
-
 my $git_dir = "$tmpdir/gittest";
 my $ibx = create_inbox 'v1', tmpdir => $git_dir, sub {
 	my ($im, $ibx) = @_;
@@ -46,13 +35,28 @@ EOF
 
 $ibx->{url} = [ 'http://example.com/test' ];
 $ibx->{feedmax} = 3;
+my $ctx = {
+	ibx => $ibx,
+	env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'http' },
+};
+my $string_feed = sub {
+	my $res = PublicInbox::Feed::generate($ctx);
+	my $body = $res->[2];
+	my $str = '';
+	while (defined(my $chunk = $body->getline)) {
+		$str .= $chunk;
+	}
+	$body->close;
+	$str;
+};
+
 my $im = $ibx->importer(0);
 
 # spam check
 {
 	# check initial feed
 	{
-		my $feed = string_feed({ ibx => $ibx });
+		my $feed = $string_feed->();
 		SKIP: {
 			skip 'XML::TreePP missing', 3 unless $have_xml_treepp;
 			my $t = XML::TreePP->new->parse($feed);
@@ -86,7 +90,7 @@ EOF
 
 	# check spam shows up
 	{
-		my $spammy_feed = string_feed({ ibx => $ibx });
+		my $spammy_feed = $string_feed->();
 		SKIP: {
 			skip 'XML::TreePP missing', 2 unless $have_xml_treepp;
 			my $t = XML::TreePP->new->parse($spammy_feed);
@@ -104,7 +108,7 @@ EOF
 
 	# spam no longer shows up
 	{
-		my $feed = string_feed({ ibx => $ibx });
+		my $feed = $string_feed->();
 		SKIP: {
 			skip 'XML::TreePP missing', 2 unless $have_xml_treepp;
 			my $t = XML::TreePP->new->parse($feed);