From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] view: addr2urlmap matches HTML-escaped addresses, only
Date: Fri, 13 Sep 2024 22:07:22 +0000 [thread overview]
Message-ID: <20240913220724.2958606-2-e@80x24.org> (raw)
In-Reply-To: <20240913220724.2958606-1-e@80x24.org>
Some odd email addresses may require HTML escaping, and
the resulting regexp is run on escaped HTML.
---
lib/PublicInbox/View.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 37c910f8..19f4168e 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -196,7 +196,8 @@ sub addr2urlmap ($) {
my (%addr2url, $url);
while (my ($addr, $ibx) = each %$by_addr) {
$url = $ibx->base_url // $ibx->base_url($ctx->{env});
- $addr2url{$addr} = ascii_html($url) if defined $url;
+ $addr2url{ascii_html($addr)} = ascii_html($url) if
+ defined $url;
}
# don't allow attackers to randomly change Host: headers
# and OOM us if the server handles all hostnames:
next prev parent reply other threads:[~2024-09-13 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 22:07 [PATCH 0/3] www: addr2urlmap fixes Eric Wong
2024-09-13 22:07 ` Eric Wong [this message]
2024-09-13 22:07 ` [PATCH 2/3] view: fix addr2urlmap with Plack::Builder::mount Eric Wong
2024-09-13 22:07 ` [PATCH 3/3] view: disable address URL-fication of possible HTML escapes Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913220724.2958606-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).