From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] view: fix x-post links for relative urls
Date: Tue, 10 Sep 2024 20:25:17 +0000 [thread overview]
Message-ID: <20240910202517.M408057@dcvr> (raw)
In-Reply-To: <20240910-strong-rainbow-warthog-d6fe69@lemur>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Tue, Sep 10, 2024 at 12:40:48AM GMT, Eric Wong wrote:
> > We need to make correct relative URL paths for users configuring
> > publicinbox.$NAME.url as relative URL paths (e.g. matching the
> > inbox `$NAME').
> >
> > Users of protocol-relative (e.g. `//$HOST/$NAME') and absolute URIs
> > (e.g `https://example.com/$NAME') were unaffected by this bug.
> > Users relying on publicinbox.nameIsUrl and omitting
> > publicinbox.*.url entries were also immune to this bug.
>
> I've applied the patch, but I'm not sure it's quite what was intended as none
> of the lists are linkified any more.
That shouldn't happen, and I can't seem to reproduce it,
either...
You're still using "url = $NAME" as posted in
https://public-inbox.org/meta/20240903-woodoo-airborne-harrier-6733c5@meerkat/
, right?
IOW this:
[publicinbox "tools"]
url = tools
...
next prev parent reply other threads:[~2024-09-10 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 20:55 Bug: mailing list linkification in headers incorrect Konstantin Ryabitsev
2024-09-09 21:15 ` Filip Hejsek
2024-09-09 22:11 ` Eric Wong
2024-09-10 14:07 ` Konstantin Ryabitsev
2024-09-10 14:05 ` [PATCH] view: fix x-post links for relative urls Konstantin Ryabitsev
2024-09-10 20:25 ` Eric Wong [this message]
2024-09-10 20:29 ` Konstantin Ryabitsev
2024-09-11 21:25 ` [PATCH] www: preload all inboxes if using ->ALL Eric Wong
2024-09-12 15:19 ` Konstantin Ryabitsev
2024-09-12 21:33 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910202517.M408057@dcvr \
--to=e@80x24.org \
--cc=konstantin@linuxfoundation.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).