* [PATCH] view: fix mismatched quote in HTML
@ 2024-09-06 21:06 Filip Hejsek
2024-09-06 22:02 ` Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Filip Hejsek @ 2024-09-06 21:06 UTC (permalink / raw)
To: meta
Fixes: 5ca29b7f2789517f (view: reduce ascii_html calls and {obuf} use, 2022-09-10)
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 131727fc..bc093a20 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -726,7 +726,7 @@ href="d/">diff</a>)</pre><pre>];
$hbuf .= qq{\t<a\nhref="#r">[thread overview]</a>\n};
$hbuf =~ s!^Subject:\x20(.*?)(\n[A-Z]|\z)
!Subject: <a\nhref="#r"\nid=t>$1</a>$2!msx or
- $hbuf .= qq(<a\nhref="#r\nid=t></a>);
+ $hbuf .= qq(<a\nhref="#r"\nid=t></a>);
}
if (scalar(@$mids) == 1) { # common case
my $x = ascii_html($mids->[0]);
base-commit: 5363bc5ad0771c9de09b6add56a352687af13f2e
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] view: fix mismatched quote in HTML
2024-09-06 21:06 [PATCH] view: fix mismatched quote in HTML Filip Hejsek
@ 2024-09-06 22:02 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2024-09-06 22:02 UTC (permalink / raw)
To: Filip Hejsek; +Cc: meta
Filip Hejsek <filip.hejsek@gmail.com> wrote:
> Fixes: 5ca29b7f2789517f (view: reduce ascii_html calls and {obuf} use, 2022-09-10)
> ---
> lib/PublicInbox/View.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
> index 131727fc..bc093a20 100644
> --- a/lib/PublicInbox/View.pm
> +++ b/lib/PublicInbox/View.pm
> @@ -726,7 +726,7 @@ href="d/">diff</a>)</pre><pre>];
> $hbuf .= qq{\t<a\nhref="#r">[thread overview]</a>\n};
> $hbuf =~ s!^Subject:\x20(.*?)(\n[A-Z]|\z)
> !Subject: <a\nhref="#r"\nid=t>$1</a>$2!msx or
> - $hbuf .= qq(<a\nhref="#r\nid=t></a>);
> + $hbuf .= qq(<a\nhref="#r"\nid=t></a>);
Thanks, I failed to check with subject-less messages :x
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-06 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06 21:06 [PATCH] view: fix mismatched quote in HTML Filip Hejsek
2024-09-06 22:02 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).