From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 383641F548; Fri, 6 Sep 2024 22:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1725660343; bh=HOvT04Dk679MRKfwWmMykpvIuqTRRaUSspxGeaYTBn8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qGjZnvG93d2/N0kOBELbw9olKwEAPFvxAJXeJgkFCsR9Z5GoIT1Ll6Cz6u2Id1eM+ +K5eDNkBLRiX4hYgnJ/ArHRZAqHRecLqRPSccMryND4o9XYpDC0UqOsD6VJjW2Jq2c Fi49cwTXQckFP3BFshvvGXrSH93yULTv72Jqvo2g= Date: Fri, 6 Sep 2024 22:02:47 +0000 From: Eric Wong To: Filip Hejsek Cc: meta@public-inbox.org Subject: Re: [PATCH] view: fix mismatched quote in HTML Message-ID: <20240906220247.M351276@dcvr> References: <3fe4683ddc8095f6eed5359ebc41ced5cee0fe63.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3fe4683ddc8095f6eed5359ebc41ced5cee0fe63.camel@gmail.com> List-Id: Filip Hejsek wrote: > Fixes: 5ca29b7f2789517f (view: reduce ascii_html calls and {obuf} use, 2022-09-10) > --- > lib/PublicInbox/View.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm > index 131727fc..bc093a20 100644 > --- a/lib/PublicInbox/View.pm > +++ b/lib/PublicInbox/View.pm > @@ -726,7 +726,7 @@ href="d/">diff)
];
>  		$hbuf .= qq{\t[thread overview]\n};
>  		$hbuf =~ s!^Subject:\x20(.*?)(\n[A-Z]|\z)
>  				!Subject: $1$2!msx or
> -			$hbuf .= qq();
> +			$hbuf .= qq();

Thanks, I failed to check with subject-less messages :x