unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Filip Hejsek <filip.hejsek@gmail.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] view: fix mismatched quote in HTML
Date: Fri, 6 Sep 2024 22:02:47 +0000	[thread overview]
Message-ID: <20240906220247.M351276@dcvr> (raw)
In-Reply-To: <3fe4683ddc8095f6eed5359ebc41ced5cee0fe63.camel@gmail.com>

Filip Hejsek <filip.hejsek@gmail.com> wrote:
> Fixes: 5ca29b7f2789517f (view: reduce ascii_html calls and {obuf} use, 2022-09-10)
> ---
>  lib/PublicInbox/View.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
> index 131727fc..bc093a20 100644
> --- a/lib/PublicInbox/View.pm
> +++ b/lib/PublicInbox/View.pm
> @@ -726,7 +726,7 @@ href="d/">diff</a>)</pre><pre>];
>  		$hbuf .= qq{\t<a\nhref="#r">[thread overview]</a>\n};
>  		$hbuf =~ s!^Subject:\x20(.*?)(\n[A-Z]|\z)
>  				!Subject: <a\nhref="#r"\nid=t>$1</a>$2!msx or
> -			$hbuf .= qq(<a\nhref="#r\nid=t></a>);
> +			$hbuf .= qq(<a\nhref="#r"\nid=t></a>);

Thanks, I failed to check with subject-less messages :x

      reply	other threads:[~2024-09-06 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 21:06 [PATCH] view: fix mismatched quote in HTML Filip Hejsek
2024-09-06 22:02 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906220247.M351276@dcvr \
    --to=e@80x24.org \
    --cc=filip.hejsek@gmail.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).