From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 93E4A1F548;
	Wed,  4 Sep 2024 13:14:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1725455683;
	bh=nlwQRJz5CnY4tSaPu6nrSnjZsLpj3QJYs7fBoNcHXdU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=x7uA7zNXLDcy1Hie79e1zVIO29DEYu0LZXWOHB9iIcv3dyfRbXnZj2BWD+XF+TE2l
	 gJvTJPX+YtqbN77uyUSbsbyhAqw42jKm3FpewCXPrBVhsjempFza8+Q7UdslbJdnNo
	 /ehrz27gdTmrAaZtbWLioBA/PBXordYT9EIhKJRQ=
Date: Wed, 4 Sep 2024 13:14:43 +0000
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: Occasional web view corruption (extra html escapes)
Message-ID: <20240904131443.M476652@dcvr>
References: <20240903-brainy-lionfish-of-saturation-71ae1a@lemur>
 <20240903191151.M126396@dcvr>
 <20240903-woodoo-airborne-harrier-6733c5@meerkat>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240903-woodoo-airborne-harrier-6733c5@meerkat>
List-Id: <meta.public-inbox.org>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Tue, Sep 03, 2024 at 07:11:51PM GMT, Eric Wong wrote:
> > Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> > > In the HTML source, I see:
> > > 
> > > 	<a
> > > 	href="?t=20240829184845"></a>From<a
> > 
> > By any chance, do you have empty `address =' entries in the
> > public-inbox config file?
>
> Doesn't appear to be the case. The config is:
> 
>     [include]
>       path = /etc/public-inbox/config.include
>     [publicinbox "tools"]
>       address = tools@linux.kernel.org
>       url = tools
>       inboxdir = /srv/public-inbox/lore.kernel.org/tools
>       indexlevel = basic
>       newsgroup = org.kernel.linux.tools
>       boost = 10
>       listid = tools.linux.kernel.org
>     (repeat for every list)

OK, and nothing malformed or commented out in the address=
fields?  And no stray semi-colons or hash marks in any address
fields which comment out only the value?

Because having an empty address= and empty url= field in my
publicinbox.lkml section gives me something close (but not
exactly) to what you have:

<a
href="/?t=20240829184845"></a> &<a
href="/?t=20240829184845"></a>lt<a
href="/?t=20240829184845"></a>;<a

Note the href has a leading slash in my near-reproduction
but yours did not.

It's not a double-escaping problem, but the substituion is
is breaking already -escaped `&lt;' and `&gt;' apart with <a>
tags in between characters.  but I'm not sure how this is
happening to you if all your address fields look OK.

I'll filter out blank addresses in our config reader, but
I also wonder if there's anything else going on...

And all your writes to the config are via git-config?
(or public-inbox-config)  IOW, it's not possible for a
partially-written config file to be read because git-config
writes atomically via rename(2).

Fwiw, the buggy code would be in addr2urlmap called by
_msg_page_prepare in PublicInbox::View.
addr2urlmap() will escape any regexp metacharacters present in
addresses via quotemeta, so there's no chance of regexp
injection from a config.

(hopefully coherent, running on fumes due to real life things)