From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id BB3E21F47A;
	Fri, 30 Aug 2024 20:36:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1725050195;
	bh=F6Huu/bUZH0koPDJEKiImLqZRO+1JkU3YLhtFiZDjZg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=W8uiTcdmTJgwZAJDbgNl9xdy4Jub3VBjRXo0vzhN19dV/aUCHJ9eiQQ8MoiASvHaO
	 NSEqtsNODaX0uJsfl3PH9J5pwTbFMMudtwSkoWvsXUQXqVVPrGyr9il+7RGZKxjhel
	 7ogLo0YyyuCZT3SztyILd7IOwtQ1Jva+UHPCntyM=
Date: Fri, 30 Aug 2024 20:36:35 +0000
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: [PATCH] view: fix unclosed parentheses after `raw' link
Message-ID: <20240830203635.M599683@dcvr>
References: <20240830-crystal-active-dingo-03bfbd@lemur>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240830-crystal-active-dingo-03bfbd@lemur>
List-Id: <meta.public-inbox.org>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> This is completely inconsequential, but it's driving my OCD into a bad place.
> There is a missing paren in the header of each message:
> 
> 	* Committing crimes with NTFS-3G
> 	@ 2024-08-29 20:43 XXXXXXXXX
> 	  2024-08-30  0:47 ` XXXXXXXXXXXX
> 					   ` (2 more replies)
> 	  0 siblings, 3 replies; 9+ messages in thread
> 	From: XXXXXXX @ 2024-08-29 20:43 UTC (permalink / raw
>                                                          ^ :(
> 	  To: git
> 
> It can be seen live here:
> https://lore.kernel.org/all/fe9d19fa-661d-4358-aa0a-ea419c419266@gaijin.team/T/#t
> 
> Any way to get it fixed? :)

Not OCD at all and definitely a bug, thanks for the report :>

------8<----
Subject: [PATCH] view: fix unclosed parentheses after `raw' link

This formatting error was accidentally introduced while
converting a `qq{}' concatenation to a `say' statement.  Re-add
the `)'.   While we're at it, switch to a `print' statement
since we use a string literal anyways and `say' would require an
extra global variable lookup at runtime.

Fixes: 18f41f5af397f903 (www: replace *eml_entry with *emit_eml, 2024-07-07)
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20240830-crystal-active-dingo-03bfbd@lemur/
---
 lib/PublicInbox/View.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ce8fa865..131727fc 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -270,9 +270,9 @@ sub emit_eml ($$) {
 	obfuscate_addrs($obfs_ibx, $from) if $obfs_ibx;
 	my $upfx = $ctx->{-upfx};
 	my $mhref = $upfx . mid_href($mid_raw) . '/';
-	say $zfh 'From: ', $from, ' @ ', fmt_ts($ds), qq[ UTC (<a\nhref="],
+	print $zfh 'From: ', $from, ' @ ', fmt_ts($ds), qq[ UTC (<a\nhref="],
 			$mhref, qq[">permalink</a> / <a\nhref="],
-			$mhref, 'raw">raw</a>';
+			$mhref, qq[raw">raw</a>)\n];
 	{
 		my ($to, $tlen) = to_cc_html($ctx, $eml, 'To', $t);
 		my ($cc, $clen) = to_cc_html($ctx, $eml, 'Cc', $t);