From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] view: fix unclosed parentheses after `raw' link
Date: Fri, 30 Aug 2024 17:31:32 -0400 [thread overview]
Message-ID: <20240830-illegal-amazing-quetzal-dbefba@lemur> (raw)
In-Reply-To: <20240830203635.M599683@dcvr>
On Fri, Aug 30, 2024 at 08:36:35PM GMT, Eric Wong wrote:
> > It can be seen live here:
> > https://lore.kernel.org/all/fe9d19fa-661d-4358-aa0a-ea419c419266@gaijin.team/T/#t
> >
> > Any way to get it fixed? :)
>
> Not OCD at all and definitely a bug, thanks for the report :>
>
I knew I couldn't possibly be the only one. :)
> This formatting error was accidentally introduced while
> converting a `qq{}' concatenation to a `say' statement. Re-add
> the `)'. While we're at it, switch to a `print' statement
> since we use a string literal anyways and `say' would require an
> extra global variable lookup at runtime.
Tested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Thanks!
-K
prev parent reply other threads:[~2024-08-30 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 19:37 OCD request: missing paren in web view Konstantin Ryabitsev
2024-08-30 20:36 ` [PATCH] view: fix unclosed parentheses after `raw' link Eric Wong
2024-08-30 21:31 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830-illegal-amazing-quetzal-dbefba@lemur \
--to=konstantin@linuxfoundation.org \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).