OCD request: missing paren in web view

OCD request: missing paren in web view

[Konstantin Ryabitsev]

Eric:

This is completely inconsequential, but it's driving my OCD into a bad place.
There is a missing paren in the header of each message:

	* Committing crimes with NTFS-3G
	@ 2024-08-29 20:43 XXXXXXXXX
	  2024-08-30  0:47 ` XXXXXXXXXXXX
					   ` (2 more replies)
	  0 siblings, 3 replies; 9+ messages in thread
	From: XXXXXXX @ 2024-08-29 20:43 UTC (permalink / raw
                                                         ^ :(
	  To: git

It can be seen live here:
https://lore.kernel.org/all/fe9d19fa-661d-4358-aa0a-ea419c419266@gaijin.team/T/#t

Any way to get it fixed? :)

-K

[PATCH] view: fix unclosed parentheses after `raw' link

[Eric Wong]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> This is completely inconsequential, but it's driving my OCD into a bad place.
> There is a missing paren in the header of each message:
> 
> 	* Committing crimes with NTFS-3G
> 	@ 2024-08-29 20:43 XXXXXXXXX
> 	  2024-08-30  0:47 ` XXXXXXXXXXXX
> 					   ` (2 more replies)
> 	  0 siblings, 3 replies; 9+ messages in thread
> 	From: XXXXXXX @ 2024-08-29 20:43 UTC (permalink / raw
>                                                          ^ :(
> 	  To: git
> 
> It can be seen live here:
> https://lore.kernel.org/all/fe9d19fa-661d-4358-aa0a-ea419c419266@gaijin.team/T/#t
> 
> Any way to get it fixed? :)

Not OCD at all and definitely a bug, thanks for the report :>

------8<----
Subject: [PATCH] view: fix unclosed parentheses after `raw' link

This formatting error was accidentally introduced while
converting a `qq{}' concatenation to a `say' statement.  Re-add
the `)'.   While we're at it, switch to a `print' statement
since we use a string literal anyways and `say' would require an
extra global variable lookup at runtime.

Fixes: 18f41f5af397f903 (www: replace *eml_entry with *emit_eml, 2024-07-07)
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20240830-crystal-active-dingo-03bfbd@lemur/
---
 lib/PublicInbox/View.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ce8fa865..131727fc 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -270,9 +270,9 @@ sub emit_eml ($$) {
 	obfuscate_addrs($obfs_ibx, $from) if $obfs_ibx;
 	my $upfx = $ctx->{-upfx};
 	my $mhref = $upfx . mid_href($mid_raw) . '/';
-	say $zfh 'From: ', $from, ' @ ', fmt_ts($ds), qq[ UTC (<a\nhref="],
+	print $zfh 'From: ', $from, ' @ ', fmt_ts($ds), qq[ UTC (<a\nhref="],
 			$mhref, qq[">permalink</a> / <a\nhref="],
-			$mhref, 'raw">raw</a>';
+			$mhref, qq[raw">raw</a>)\n];
 	{
 		my ($to, $tlen) = to_cc_html($ctx, $eml, 'To', $t);
 		my ($cc, $clen) = to_cc_html($ctx, $eml, 'Cc', $t);

Re: [PATCH] view: fix unclosed parentheses after `raw' link

[Konstantin Ryabitsev]

On Fri, Aug 30, 2024 at 08:36:35PM GMT, Eric Wong wrote:
> > It can be seen live here:
> > https://lore.kernel.org/all/fe9d19fa-661d-4358-aa0a-ea419c419266@gaijin.team/T/#t
> > 
> > Any way to get it fixed? :)
> 
> Not OCD at all and definitely a bug, thanks for the report :>
> 

I knew I couldn't possibly be the only one. :)

> This formatting error was accidentally introduced while
> converting a `qq{}' concatenation to a `say' statement.  Re-add
> the `)'.   While we're at it, switch to a `print' statement
> since we use a string literal anyways and `say' would require an
> extra global variable lookup at runtime.

Tested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

Thanks!
-K