Re: [PATCH 2/4] msgmap: mid_insert: reraise on unexpected errors, [PATCH 3/4] t/v2writable: test ENOSPC from fast-import

[Eric Wong <e@80x24.org>]

Štěpán Němec <stepnem@smrk.net> wrote:
> Just a few nits in the new test messages, if I may:
> 
> [2/4]:
> > +	like $@, qr/ disk is full/, 'set $@ for ENOSPC';
>                                      ^^^^^^^^^^^^^^^^^
> 
> [3/4]:
> > +	$rd->poll_in(10) or die 'strace not ready';
> > +	ok !eval { $im->done }, 'done fails with ENOSPC';
> > +	ok $@, '$@ set on ENOSPC';
>                 ^^^^^^^^^^^^^^^^
> If I'm correct in assuming that no semantic nuance is
> intended between the 'set $@ for ENOSPC' and '$@ set on
> ENOSPC' variants, I suggest unifying on the latter (the
> unequivocal passive reads clearer than the
> imperative-looking 'set $@').

The former ensures $@ matches qr/ disk is full/,
while the latter merely ensures $@ is set to a true value.

Arguably, the former could be '$@ reports ENOSPC'  *shrug*

> > +	$im->add($eml) or xbail '->add fail after fixing ENOSPC';
> 
> s/fail/fails/ ?
> 
> > +	$im->done;
> > +	ok !$im->add($eml), '->add detects existing message';
> > +	$im->done;
> > +	is -s $fh, 0, 'nothing new fast-import stderr';
> 
> s/new/new on/ ?

Will fix for v2.  Thanks.