unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] inotify: don't load Linux::Inotify2 if pure Perl is usable
@ 2024-07-23 22:07 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2024-07-23 22:07 UTC (permalink / raw)
  To: meta

No need to bring systems closer to the vm.max_map_count limit
with more .so objects loaded.
---
 lib/PublicInbox/Inotify.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Inotify.pm b/lib/PublicInbox/Inotify.pm
index c4f1ae84..5553c643 100644
--- a/lib/PublicInbox/Inotify.pm
+++ b/lib/PublicInbox/Inotify.pm
@@ -1,7 +1,7 @@
 # Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
-# wrap Linux::Inotify2 XS module, support pure Perl via `syscall' someday
+# loads either pure Perl inotify support or wrap Linux::Inotify2 XS module
 package PublicInbox::Inotify;
 use v5.12;
 our @ISA;
@@ -11,13 +11,14 @@ BEGIN { # prefer pure Perl since it works out-of-the-box
 		eval "require $m";
 		next if $@;
 		$isa = $m;
+		last;
 	}
 	if ($isa) {
 		push @ISA, $isa;
 		my $buf = '';
 		for (qw(IN_MOVED_TO IN_CREATE IN_DELETE IN_DELETE_SELF
 				IN_MOVE_SELF IN_MOVED_FROM IN_MODIFY)) {
-			$buf .= "*$_ = \\&PublicInbox::Inotify3::$_;\n";
+			$buf .= "*$_ = \\&${isa}::$_;\n";
 		}
 		eval $buf;
 		die $@ if $@;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2024-07-23 22:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 22:07 [PATCH] inotify: don't load Linux::Inotify2 if pure Perl is usable Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).