unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] inotify: don't load Linux::Inotify2 if pure Perl is usable
Date: Tue, 23 Jul 2024 22:07:00 +0000	[thread overview]
Message-ID: <20240723220700.3933900-1-e@80x24.org> (raw)

No need to bring systems closer to the vm.max_map_count limit
with more .so objects loaded.
---
 lib/PublicInbox/Inotify.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Inotify.pm b/lib/PublicInbox/Inotify.pm
index c4f1ae84..5553c643 100644
--- a/lib/PublicInbox/Inotify.pm
+++ b/lib/PublicInbox/Inotify.pm
@@ -1,7 +1,7 @@
 # Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
-# wrap Linux::Inotify2 XS module, support pure Perl via `syscall' someday
+# loads either pure Perl inotify support or wrap Linux::Inotify2 XS module
 package PublicInbox::Inotify;
 use v5.12;
 our @ISA;
@@ -11,13 +11,14 @@ BEGIN { # prefer pure Perl since it works out-of-the-box
 		eval "require $m";
 		next if $@;
 		$isa = $m;
+		last;
 	}
 	if ($isa) {
 		push @ISA, $isa;
 		my $buf = '';
 		for (qw(IN_MOVED_TO IN_CREATE IN_DELETE IN_DELETE_SELF
 				IN_MOVE_SELF IN_MOVED_FROM IN_MODIFY)) {
-			$buf .= "*$_ = \\&PublicInbox::Inotify3::$_;\n";
+			$buf .= "*$_ = \\&${isa}::$_;\n";
 		}
 		eval $buf;
 		die $@ if $@;

                 reply	other threads:[~2024-07-23 22:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240723220700.3933900-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).