From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] http: don't requeue if using write buffer
Date: Thu, 4 Jul 2024 02:20:55 +0000 [thread overview]
Message-ID: <20240704022056.2148748-1-e@80x24.org> (raw)
The write buffering will already be processed inside
->event_step, so requeue will cause a needless read(2) outside
of epoll_wait/kevent(2) readiness notifications.
This ought to avoid problems in case of pipelined connections,
but those aren't possible behind a reverse proxy and AFAIK most
HTTP clients don't do pipelining. This bug was only noticed via
strace while searching for extra syscalls, and not from
real-world use.
---
lib/PublicInbox/HTTP.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 4ccb1b81..88cab544 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -247,7 +247,8 @@ sub response_done {
delete $self->{env}; # we're no longer busy
# HEAD requests set $alive = 3 so we don't send "0\r\n\r\n";
$self->write(\"0\r\n\r\n") if $alive == 2;
- $self->write($alive ? $self->can('requeue') : \&close);
+ $self->write(\&close) if !$alive;
+ $self->requeue if $alive && !$self->{wbuf};
}
sub getline_pull {
@@ -280,7 +281,7 @@ sub getline_pull {
}
} elsif ($@) {
warn "response ->getline error: $@";
- $self->close;
+ return $self->close;
}
response_done($self, delete $self->{alive});
}
reply other threads:[~2024-07-04 2:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704022056.2148748-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).