unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/1] lei_mirror: show FS path for symlink conflicts
Date: Tue, 2 Jul 2024 23:56:49 +0000	[thread overview]
Message-ID: <20240702235649.M115127@dcvr> (raw)
In-Reply-To: <20240702213533.3941056-1-e@80x24.org>

Seeing the URI path component is confusing the problem needs to
be dealt with on the local FS.
---
 lib/PublicInbox/LeiMirror.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index 57b2d32b..fb0295da 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -794,7 +794,7 @@ sub update_ent {
 					next if readlink($ln) eq $tgt;
 					unlink($ln);
 				} else {
-					push @{$self->{chg}->{badlink}}, $p;
+					push @{$self->{chg}->{badlink}}, $ln;
 					next;
 				}
 			}

      reply	other threads:[~2024-07-02 23:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 21:35 [PATCH] lei_mirror: don't symlink(2) over bad links Eric Wong
2024-07-02 23:56 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702235649.M115127@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).