From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] http: fix 304 responses w/o entity body w/o reverse proxy
Date: Tue, 2 Jul 2024 23:27:03 +0000 [thread overview]
Message-ID: <20240702232703.4079037-1-e@80x24.org> (raw)
This was hidden by instances using varnish <and|or> nginx;
but is readily apparent when hitting static manifest.js.gz
when using `curl -z'
---
lib/PublicInbox/HTTP.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index bead222e..4ccb1b81 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -189,7 +189,8 @@ sub response_header_write ($$$) {
}
my $conn = $env->{HTTP_CONNECTION} || '';
- my $term = defined($len) || $chunked;
+ my $term = defined($len) || $chunked ||
+ Plack::Util::status_with_no_entity_body($status);
my $prot_persist = ($proto eq 'HTTP/1.1') && ($conn !~ /\bclose\b/i);
my ($alive, $res_body);
if (!$term && ref($res->[2]) eq 'ARRAY') {
reply other threads:[~2024-07-02 23:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702232703.4079037-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).