[PATCH] lei_mirror: don't symlink(2) over bad links

[PATCH] lei_mirror: don't symlink(2) over bad links

[Eric Wong]

We don't want to autodie on symlink(2) failures here.  Instead,
just note the {badlink} and display it at the end instead of
bailing out early.
---
 lib/PublicInbox/LeiMirror.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index e7c265bd..57b2d32b 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -795,6 +795,7 @@ sub update_ent {
 					unlink($ln);
 				} else {
 					push @{$self->{chg}->{badlink}}, $p;
+					next;
 				}
 			}
 			symlink($tgt, $ln);

[PATCH 2/1] lei_mirror: show FS path for symlink conflicts

[Eric Wong]

Seeing the URI path component is confusing the problem needs to
be dealt with on the local FS.
---
 lib/PublicInbox/LeiMirror.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index 57b2d32b..fb0295da 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -794,7 +794,7 @@ sub update_ent {
 					next if readlink($ln) eq $tgt;
 					unlink($ln);
 				} else {
-					push @{$self->{chg}->{badlink}}, $p;
+					push @{$self->{chg}->{badlink}}, $ln;
 					next;
 				}
 			}