From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7FA6DD4813; Wed, 26 Jun 2024 17:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1719424108; bh=+ZCRpx6JTGrERhAF9SkVtJGUaDFyQOElvuSsJr/wo18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HjY1sDQRvnl7oqX17Jd80Z5mar0QC+/vQSd+TghPhazqderl2v2kOzaueFXfBp5oS D+pRazyYLXnSyiwV/1V55a1KzxySejCWqbAIE+Rm7TVRZc8OOz1gzgBc0BjnEq08WP IKpknhDRjeh3ddERJ48MLLNT2HrmvGNCxfmsyEq8= Date: Wed, 26 Jun 2024 17:48:28 +0000 From: Eric Wong To: meta@public-inbox.org Cc: =?utf-8?Q?C=C3=A9dric?= Hannotier , Konstantin Ryabitsev Subject: [PATCH] www_listing: add space after `input=text' in search field Message-ID: <20240626174828.M325671@dcvr> References: <20240626-invaluable-apricot-skunk-6dace5@meerkat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240626-invaluable-apricot-skunk-6dace5@meerkat> List-Id: Konstantin Ryabitsev wrote: > On Wed, Jun 26, 2024 at 11:17:28AM GMT, Cédric Hannotier wrote: > > In [1], the input form has a typo in the type of the field 'q', > > i.e. it is written `` instead of > > `` (there is a trailing '/' in the type). Thanks, fix below. > > By the way, after reading [2], > > I have the feeling that `type="search"` would be a better type. > > But I have 0 expertise in web design, so I may miss something. > > > > [1] https://lore.kernel.org/ > > [2] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input We must support old text-only browsers since users may be searching archives when they have unsupported graphics drivers or too little RAM and unable to run modern HTML5 browsers. -----8<----- Subject: [PATCH] www_listing: add space after `input=text' in search field Having an attribute value glued to an HTML closing tag may cause problems with some parsers. Reported-by: Cédric Hannotier --- lib/PublicInbox/WwwListing.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm index 2d6c74da..5681377f 100644 --- a/lib/PublicInbox/WwwListing.pm +++ b/lib/PublicInbox/WwwListing.pm @@ -179,7 +179,7 @@ sub mset_nav_top { $qh = qq[\nvalue="].ascii_html($qh).'"'; } chop(my $rv = <
 EOM