Re: Wrong input type in lore.kernel.org webpage

Re: Wrong input type in lore.kernel.org webpage

[Konstantin Ryabitsev]

On Wed, Jun 26, 2024 at 11:17:28AM GMT, Cédric Hannotier wrote:
> Dear Mr. Ryabitsev,
> 
> I apologize if this is not the correct email address
> or the way to report a bug in the web interface of the kernel ML.
> I tried to find out,
> but eventually, someone on #kernel pointed fingers at you...

I'm not quite the right person to handle your request, but I'm cc'ing the
public-inbox meta list, who may be able to properly reply.

> In [1], the input form has a typo in the type of the field 'q',
> i.e. it is written `<input name="q" type="text/">` instead of
> `<input name="q" type="text">` (there is a trailing '/' in the type).
> 
> By the way, after reading [2],
> I have the feeling that `type="search"` would be a better type.
> But I have 0 expertise in web design, so I may miss something.
> 
> [1] https://lore.kernel.org/
> [2] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input

-K

[PATCH] www_listing: add space after `input=text' in search field

[Eric Wong]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Wed, Jun 26, 2024 at 11:17:28AM GMT, Cédric Hannotier wrote:
> > In [1], the input form has a typo in the type of the field 'q',
> > i.e. it is written `<input name="q" type="text/">` instead of
> > `<input name="q" type="text">` (there is a trailing '/' in the type).

Thanks, fix below.

> > By the way, after reading [2],
> > I have the feeling that `type="search"` would be a better type.
> > But I have 0 expertise in web design, so I may miss something.
> > 
> > [1] https://lore.kernel.org/
> > [2] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input

We must support old text-only browsers since users may be
searching archives when they have unsupported graphics drivers
or too little RAM and unable to run modern HTML5 browsers.

-----8<-----
Subject: [PATCH] www_listing: add space after `input=text' in search field

Having an attribute value glued to an HTML closing tag may
cause problems with some parsers.

Reported-by: Cédric Hannotier <cedric.hannotier@ulb.be>
---
 lib/PublicInbox/WwwListing.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index 2d6c74da..5681377f 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -179,7 +179,7 @@ sub mset_nav_top {
 		$qh = qq[\nvalue="].ascii_html($qh).'"';
 	}
 	chop(my $rv = <<EOM);
-<form action="./"><pre><input name=q type=text$qh/><input
+<form action="./"><pre><input name=q type=text$qh /><input
 type=submit value="locate inbox"/><input type=submit name=a
 value="search all inboxes"/></pre></form><pre>
 EOM