[PATCH] imap: use spec compliant continuation request

[PATCH] imap: use spec compliant continuation request

[Manos Pitsidianakis]

cmd_authenticate() replies to AUTHENTICATE commands with "+" CRLF but
the imap4rev1 RFC [^0] defines the following ABNF syntax for a continuation
request:

	continue-req    = "+" SP (resp-text / base64) CRLF

A space (SP) is required before CRLF.

[0]: https://www.rfc-editor.org/rfc/rfc3501#page-84

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
---
 lib/PublicInbox/IMAP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 0eb21b6a..378a0363 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -158,7 +158,7 @@ sub cmd_logout ($$) {
 sub cmd_authenticate ($$$) {
 	my ($self, $tag) = @_; # $method = $_[2], should be "ANONYMOUS"
 	$self->{-login_tag} = $tag;
-	"+\r\n"; # challenge
+	"+ \r\n"; # challenge
 }
 
 sub cmd_capability ($$) {

base-commit: f4844140d92d24493ce9acb4311f3df0edf5a449
-- 
γαῖα πυρί μιχθήτω

Re: [PATCH] imap: use spec compliant continuation request

[Eric Wong]

Manos Pitsidianakis <manos@pitsidianak.is> wrote:
> cmd_authenticate() replies to AUTHENTICATE commands with "+" CRLF but
> the imap4rev1 RFC [^0] defines the following ABNF syntax for a continuation
> request:
> 
> 	continue-req    = "+" SP (resp-text / base64) CRLF
> 
> A space (SP) is required before CRLF.

Thanks for the fix.  Pushed as 7bdfb48c3f2c1084f2a7112e039bc0ca0d42c1c1
Curious, did you notice this in another IMAP client or something else?
Either way, great to see IMAP getting more attention :>

Re: [PATCH] imap: use spec compliant continuation request

[Manos Pitsidianakis]

On Tue, 25 Jun 2024 20:52, Eric Wong <e@80x24.org> wrote:
>Manos Pitsidianakis <manos@pitsidianak.is> wrote:
>> cmd_authenticate() replies to AUTHENTICATE commands with "+" CRLF but
>> the imap4rev1 RFC [^0] defines the following ABNF syntax for a continuation
>> request:
>> 
>> 	continue-req    = "+" SP (resp-text / base64) CRLF
>> 
>> A space (SP) is required before CRLF.
>
>Thanks for the fix.  Pushed as 7bdfb48c3f2c1084f2a7112e039bc0ca0d42c1c1
>Curious, did you notice this in another IMAP client or something else?
>Either way, great to see IMAP getting more attention :>

Noticed this in my own backend imap client library I use for my terminal 
e-mail client meli. <https://git.meli-email.org/meli/meli/>

I'm working on higher-level patch-flow mailing list integrations [after 
years of working on the basics of a mail client first :-)] and plan on 
using public-inbox like servers for fetching arbitrary messages from 
lists.

Cheers!

Undelivered replies [was: [PATCH] imap: use spec compliant continuation request]

[Eric Wong]

Btw, I'm getting this error for your address:

<manos@pitsidianak.is>: Host or domain name not found. Name service error for
    name=mail.nessuent.xyz type=AAAA: Host not found

$ host -t mx pitsidianak.is
pitsidianak.is mail is handled by 10 mail.nessuent.xyz.

The Received: header in your messages says mail.nessuent.net, not .xyz