From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 610211F7BE; Tue, 25 Jun 2024 17:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1719337999; bh=LnpAP4wENkCBAF9/DoTOAnQy3IHPWel+SJBUl7qEGUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KP3/5CqXD1ssXWDkZg9g0/PjTfshKQATVAGJJU/amorBGVPemxsBLfwkAQpqbJjnz YQJUoH1BIbN7wnq+wW5h0iZ3OD8Lmfl0KSBTW0ZrZ7eMUzLjN3eUYBYMPE494Lzc6x YHF1t7PTah/r+OWP7t5wkQB5Wqfqopify4a4KEJk= Date: Tue, 25 Jun 2024 17:52:48 +0000 From: Eric Wong To: Manos Pitsidianakis Cc: meta@public-inbox.org Subject: Re: [PATCH] imap: use spec compliant continuation request Message-ID: <20240625175248.M565435@dcvr> References: <20240625122654.3764548-1-manos@pitsidianak.is> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240625122654.3764548-1-manos@pitsidianak.is> List-Id: Manos Pitsidianakis wrote: > cmd_authenticate() replies to AUTHENTICATE commands with "+" CRLF but > the imap4rev1 RFC [^0] defines the following ABNF syntax for a continuation > request: > > continue-req = "+" SP (resp-text / base64) CRLF > > A space (SP) is required before CRLF. Thanks for the fix. Pushed as 7bdfb48c3f2c1084f2a7112e039bc0ca0d42c1c1 Curious, did you notice this in another IMAP client or something else? Either way, great to see IMAP getting more attention :>