From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] searchview: avoid uninitialized vals in %rmap_inc
Date: Wed, 5 Jun 2024 20:03:23 +0000 [thread overview]
Message-ID: <20240605200323.1418141-1-e@80x24.org> (raw)
Modules (e.g. `PublicInbox::Gcf2') may have an undef value in
the %rmap_inc hash table if an attempt has been made to load it
and failed due to a missing libgit2-dev dependency. Avoid using
it in interpolation to avoid warnings.
---
lib/PublicInbox/SearchView.pm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 9919e25c..9ce1b1ee 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -154,9 +154,15 @@ sub path2inc ($) {
if (my $short = $rmap_inc{$full}) {
return $short;
} elsif (!scalar(keys %rmap_inc) && -e $full) {
- %rmap_inc = map {; "$INC{$_}" => $_ } keys %INC;
+ # n.b. $INC{'PublicInbox::Gcf2'} is undef if libgit2-dev
+ # doesn't exist
+ my $f;
+ %rmap_inc = map {;
+ $f = $INC{$_};
+ defined $f ? ($f, $_) : ();
+ } keys %INC;
# fall back to basename as last resort
- $rmap_inc{$full} // (split('/', $full))[-1];
+ $rmap_inc{$full} // (split(m'/', $full))[-1];
} else {
$full;
}
reply other threads:[~2024-06-05 20:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605200323.1418141-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).