From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] git_http_backend: bypass safe.directory restrictions
Date: Mon, 3 Jun 2024 22:05:53 +0000 [thread overview]
Message-ID: <20240603220553.1535523-1-e@80x24.org> (raw)
git.git commit f4aa8c8b (fetch/clone: detect dubious ownership
of local repositories, 2024-04-10) has proven to be overly aggressive
and breaks existing setups where git-http-backend is serving
read-only repositories from reasonably trusted sources and not
running hooks of any sort.
Just mark everything as safe since our public-facing instances
have always assumed writes to all git repos come from a
different user than whatever user -netd/-httpd runs as.
---
lib/PublicInbox/GitHTTPBackend.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 396aa783..ac610d4b 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -106,7 +106,9 @@ sub serve_smart {
$env{PATH_TRANSLATED} = "$git->{git_dir}/$path";
my $rdr = input_prepare($env) or return r(500);
$rdr->{quiet} = 1;
- my $qsp = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, $rdr);
+ my $cmd = $git->cmd('http-backend');
+ splice @$cmd, 1, 0, '-c', 'safe.directory=*';
+ my $qsp = PublicInbox::Qspawn->new($cmd, \%env, $rdr);
$qsp->psgi_yield($env, $limiter, \&ghb_parse_hdr, $env, $git, $path);
}
reply other threads:[~2024-06-03 22:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603220553.1535523-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).