Re: [PATCH] search: forbid getopt(3) switch injection in query

[Eric Wong <e@80x24.org>]

Pushed with updated commit message:

1:  39ee8b08 ! 1:  3b7427bf search: forbid getopt(3) switch injection in query
    @@ Commit message
         Getopt::Long; so we use `--' to separate the query string
         from switches.
     
    -    Fortunately, this doesn't allow writes to on-disk Xapian DBs,
    -    but causes aborts on some searches or nonsensical results when
    -    using the optional external xap_helper processes.  There's no
    -    risk of data leaks since the mset xap_helper endpoint only
    -    returns document IDs (unsigned integers), and not terms.
    +    Consequences of this bug were limited to a single broken HTTP
    +    response for the requesting client.
     
    -    The biggest danger is may run systems out of space if the system
    -    is configured to write out core dumps.
    +    It didn't didn't allow writes to on-disk Xapian DBs, but caused
    +    aborts on some searches or nonsensical results when using the
    +    optional external xap_helper processes.  There was no risk of
    +    data leaks since the mset xap_helper endpoint only returns
    +    document IDs (unsigned integers), and not terms.
    +
    +    The biggest danger from this bug was that it could run systems
    +    out of space if they are configured to write out core dumps.
     
      ## lib/PublicInbox/Search.pm ##
     @@ lib/PublicInbox/Search.pm: sub async_mset {