unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] search: forbid getopt(3) switch injection in query
Date: Wed, 29 May 2024 19:26:48 +0000	[thread overview]
Message-ID: <20240529192648.M314167@dcvr> (raw)
In-Reply-To: <20240528212502.4001299-1-e@80x24.org>

Pushed with updated commit message:

1:  39ee8b08 ! 1:  3b7427bf search: forbid getopt(3) switch injection in query
    @@ Commit message
         Getopt::Long; so we use `--' to separate the query string
         from switches.
     
    -    Fortunately, this doesn't allow writes to on-disk Xapian DBs,
    -    but causes aborts on some searches or nonsensical results when
    -    using the optional external xap_helper processes.  There's no
    -    risk of data leaks since the mset xap_helper endpoint only
    -    returns document IDs (unsigned integers), and not terms.
    +    Consequences of this bug were limited to a single broken HTTP
    +    response for the requesting client.
     
    -    The biggest danger is may run systems out of space if the system
    -    is configured to write out core dumps.
    +    It didn't didn't allow writes to on-disk Xapian DBs, but caused
    +    aborts on some searches or nonsensical results when using the
    +    optional external xap_helper processes.  There was no risk of
    +    data leaks since the mset xap_helper endpoint only returns
    +    document IDs (unsigned integers), and not terms.
    +
    +    The biggest danger from this bug was that it could run systems
    +    out of space if they are configured to write out core dumps.
     
      ## lib/PublicInbox/Search.pm ##
     @@ lib/PublicInbox/Search.pm: sub async_mset {

      reply	other threads:[~2024-05-29 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 21:25 [PATCH] search: forbid getopt(3) switch injection in query Eric Wong
2024-05-29 19:26 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240529192648.M314167@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).