[PATCH 0/2] www: improve handling of missing coderepos

[PATCH 0/2] www: improve handling of missing coderepos

[Eric Wong]

This all needs to be made more robust and tested later.
But fix some of the problems I've seen in syslog for now
and hope I feel better in a few days.

Eric Wong (2):
  git: don't break from event loop if cat-file fails
  www_coderepo: improve handling of broken repos

 lib/PublicInbox/Git.pm         | 3 ++-
 lib/PublicInbox/WwwCoderepo.pm | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

[PATCH 1/2] git: don't break from event loop if cat-file fails

[Eric Wong]

`git cat-file' can OOM or fail by other means.  Don't let it
bring down the event loop with an uncaught exception.
---
 lib/PublicInbox/Git.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index a9a821ad..ff38efa1 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -639,7 +639,8 @@ sub event_step {
 	my ($self) = @_;
 	my $inflight = gcf_inflight($self);
 	if ($inflight && @$inflight) {
-		$self->cat_async_step($inflight);
+		eval { $self->cat_async_step($inflight) };
+		warn "E: $self->{git_dir}: $@" if $@;
 		return $self->close unless $self->{sock};
 		# don't loop here to keep things fair, but we must requeue
 		# if there's already-read data in pi_io_rbuf

[PATCH 2/2] www_coderepo: improve handling of broken repos

[Eric Wong]

The {readme} arrayref may be completely unset if a repo goes
missing, so account for that when the summary page runs.
---
 lib/PublicInbox/WwwCoderepo.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WwwCoderepo.pm b/lib/PublicInbox/WwwCoderepo.pm
index a5e2dc4a..8587f530 100644
--- a/lib/PublicInbox/WwwCoderepo.pm
+++ b/lib/PublicInbox/WwwCoderepo.pm
@@ -186,7 +186,7 @@ EOM
 	print $zfh "...\n" if $last;
 
 	# README
-	my ($bref, $oid, $ref_path) = @{delete $ctx->{qx_res}->{readme}};
+	my ($bref, $oid, $ref_path) = @{delete $ctx->{qx_res}->{readme} // []};
 	if ($bref) {
 		my $l = PublicInbox::Linkify->new;
 		$$bref =~ s/\s*\z//sm;