From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 591811F461 for ; Wed, 24 Apr 2024 06:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1713941087; bh=HxxZB353BIVRberX78iZUF/IVkpLXXFh+e4TtCo2f8c=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ubVjk7kmQBUJbpjFs87UF5ZGFWi62sHJmW5loOCij9qH1piVaFs0JTtOqYqtAxlC6 2R4SyCbSQ5Whngt3w/6QNUcCYZuGrspOojaMwmvWWqv+8gqeIfG4MWgVtuCfSxlzAl XdRCpO03ZzbODACTZfD8cQIwZRh5LieqKHooS/Js= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/5] searchview: get rid of unused adump callback arg Date: Wed, 24 Apr 2024 06:44:43 +0000 Message-ID: <20240424064447.523799-2-e@80x24.org> In-Reply-To: <20240424064447.523799-1-e@80x24.org> References: <20240424064447.523799-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It hasn't been used since 2016 when we started working on improved streamability of gigantic responses. Fixes: 95d4bf7aded4 (atom: switch to getline/close for response bodies, 2016-12-03) --- lib/PublicInbox/SearchView.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index 2d3e942c..4016ddeb 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -75,7 +75,7 @@ retry: $code = 404; $html = "
\n[No results found]
"; } else { - return adump($_[0], $mset, $q, $ctx) if $x eq 'A'; + return adump($mset, $q, $ctx) if $x eq 'A'; $ctx->{-html_tip} = search_nav_top($mset, $q, $ctx); return mset_thread($ctx, $mset, $q) if $x eq 't'; @@ -357,7 +357,7 @@ sub ctx_prepare { } sub adump { - my ($cb, $mset, $q, $ctx) = @_; + my ($mset, $q, $ctx) = @_; $ctx->{ids} = $ctx->{ibx}->isrch->mset_to_artnums($mset); $ctx->{search_query} = $q; # used by WwwAtomStream::atom_header PublicInbox::WwwAtomStream->response($ctx, \&adump_i);