From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 395AD1F44D;
	Mon,  8 Apr 2024 20:18:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1712607500;
	bh=mvP30pqMg8tqeoQ3mwB3mtG2WqsdNyR9W1hh2Pe5UZI=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=1K1z7abMXm59JmFm1RCuO5qSK7Zh/FbW4i90WiKls1bmfk5ltQNc8d2+fzK7noiO4
	 pyOpikie0QzNaGliBW0iKLmjA4o0lchU6wuEURWTJqBKC9dcnvPWGnME8KaORpFwQ4
	 O/LcpHe7OavgkBJ+uIUXHLIRSlyTQJBWVvv6oeu4=
Date: Mon, 8 Apr 2024 20:11:28 +0000
From: Eric Wong <e@80x24.org>
To: Gaelan Steele <gbs@canishe.com>
Cc: meta@public-inbox.org
Subject: Re: [RFT] syscall: set default constants for Inline::C platforms
Message-ID: <20240408201128.M138670@dcvr>
References: <20240129212319.98910-1-e@80x24.org>
 <20240129212319.98910-3-e@80x24.org>
 <0C20FAD1-1983-4C38-BB6C-03D9DEFC0D58@icloud.com>
 <20240408094843.M120440@dcvr>
 <29B30321-3B59-4C16-9AFF-A1E12B702D02@canishe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <29B30321-3B59-4C16-9AFF-A1E12B702D02@canishe.com>
List-Id: <meta.public-inbox.org>

Gaelan Steele <gbs@canishe.com> wrote:
>
> > On Apr 8, 2024, at 10:48 AM, Eric Wong <e@80x24.org> wrote:
> >
> >> I’m not enough of a Perl person to fully untangle this. As
> >> best I can tell, the intent is that non-Linux/BSD OSes should
> >> still work with Inline::C, but this doesn’t work in practice
> >> due to a bug?
> >
> > Right.  Patch below should fix it, test feedback appreciated.
>
> From a quick test, it seems to work: public-inbox-httpd starts
> and is happy to serve up an archive.
>
> Thanks for the quick fix!

No problem, thanks for the report and test.

> Ah, that’s the wrong email address. (My fault! My mail client
> has an unfortunate default I haven’t figured out how to change,
> and I forgot to set it before sending this time.) Would it be
> possible to use this one (gbs@canishe.com <mailto:gbs@canishe.com>) instead?

Sure, pushed as commit 832556492d3b94f9cadf9a4d249b519f30bae64d
with updated commit message:

    syscall: set default constants for Inline::C platforms

    This fixes compile errors on platforms we can't explicitly
    support from pure Perl due to the lack of syscall stability
    guarantees by the OS developers.

    Reported-by: Gaelan Steele <gbs@canishe.com>
    Tested-by: Gaelan Steele <gbs@canishe.com>