From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] tests: clarify Email::MIME is only for development
Date: Tue, 16 Jan 2024 11:52:51 +0000 [thread overview]
Message-ID: <20240116115255.3554317-2-e@80x24.org> (raw)
In-Reply-To: <20240116115255.3554317-1-e@80x24.org>
We moved to PublicInbox::Eml a while back and have no plans
to go back to using Email::MIME, so don't tempt users and
packagers to waste disk space on Email::MIME.
---
lib/PublicInbox/TestCommon.pm | 1 +
t/eml.t | 6 +++---
t/import.t | 3 ++-
t/mime.t | 4 ++--
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 25caaaa9..5f159683 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -266,6 +266,7 @@ sub require_mods {
}
return unless @need;
my $m = join(', ', @need)." missing for $0";
+ $m =~ s/\bEmail::MIME\b/Email::MIME (development purposes only)/;
skip($m, $maybe) if $maybe;
plan(skip_all => $m)
}
diff --git a/t/eml.t b/t/eml.t
index 2e6a441f..690ada57 100644
--- a/t/eml.t
+++ b/t/eml.t
@@ -1,8 +1,8 @@
#!perl -w
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use v5.10.1; # TODO: check unicode_strings w/ 5.12
use strict;
-use Test::More;
use PublicInbox::TestCommon;
use PublicInbox::MsgIter qw(msg_part_text);
my @classes = qw(PublicInbox::Eml);
@@ -355,7 +355,7 @@ if ('maxparts is a feature unique to us') {
}
SKIP: {
- require_mods('PublicInbox::MIME', 1);
+ require_mods('Email::MIME', 1);
my $eml = eml_load 't/utf8.eml';
my $mime = mime_load 't/utf8.eml';
for my $h (qw(Subject From To)) {
diff --git a/t/import.t b/t/import.t
index f1d61dae..7e2432e7 100644
--- a/t/import.t
+++ b/t/import.t
@@ -98,7 +98,8 @@ ok($@, 'Import->add fails on non-existent dir');
my @cls = qw(PublicInbox::Eml);
SKIP: {
- require_mods('PublicInbox::MIME', 1);
+ require_mods('Email::MIME', 1);
+ require PublicInbox::MIME;
push @cls, 'PublicInbox::MIME';
};
diff --git a/t/mime.t b/t/mime.t
index 471f0efa..bf54118a 100644
--- a/t/mime.t
+++ b/t/mime.t
@@ -1,10 +1,10 @@
#!perl -w
-# Copyright (C) 2017-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# This library is free software; you can redistribute it and/or modify
# it under the same terms as Perl itself.
# Artistic or GPL-1+ <https://www.gnu.org/licenses/gpl-1.0.txt>
+use v5.10.1; # TODO: check unicode_strings w/ v5.12
use strict;
-use Test::More;
use PublicInbox::TestCommon;
use PublicInbox::MsgIter;
my @classes = qw(PublicInbox::Eml);
next prev parent reply other threads:[~2024-01-16 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 11:52 [PATCH 0/5] www: coderepo updates Eric Wong
2024-01-16 11:52 ` Eric Wong [this message]
2024-01-16 11:52 ` [PATCH 2/5] examples/unsubscribe-milter@.service: use KillMode=process Eric Wong
2024-01-16 11:52 ` [PATCH 3/5] config: don't vivify invalid fields for coderepos Eric Wong
2024-01-16 11:52 ` [PATCH 4/5] config: glob2re: fix over-matching /**/foo Eric Wong
2024-01-16 11:52 ` [PATCH 5/5] www: repolist: support globbing in URL Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116115255.3554317-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).