From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2531D1F452 for ; Tue, 5 Dec 2023 09:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1701769584; bh=5YsaRuzX318hr+TqlaUiKiOeoH4UqJCIH9l5azfw6fY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=LMURmfBgqkn4xnnY4S7uPdvAvoiMGwr3a53Bnl1wQG6PFlz/66Uss/QaKIvGyZL0p OA8MaOpiE2mOs5iRySt0IiKT8FZ+97i/qQ/ArNVbeH/RioFWJfdrLIML8P8JjZKMSa jld8zWwvDW5GbFGf56fMSmxaO/lGBfjSmTSMbW7M= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] searchidx: drop redundant decl in index_git_blob_id Date: Tue, 5 Dec 2023 09:46:22 +0000 Message-ID: <20231205094623.3394786-2-e@80x24.org> In-Reply-To: <20231205094623.3394786-1-e@80x24.org> References: <20231205094623.3394786-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Oddly, Perl did not warn about this. Spotted while confirming abbreviated OIDs are also indexed when unabbreviated OIDs appear. --- lib/PublicInbox/SearchIdx.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 86c435fd..1bf471fc 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -715,7 +715,6 @@ sub nr_quiet_rm { delete($_[0]->{-quiet_rm}) // 0 } sub index_git_blob_id { my ($doc, $pfx, $objid) = @_; - my $len = length($objid); for (my $len = length($objid); $len >= 7; ) { $doc->add_term($pfx.$objid); $objid = substr($objid, 0, --$len);