From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8A69A1F406 for ; Fri, 24 Nov 2023 09:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1700819774; bh=m8kUUXL62KdwNdJeEs0JiBNJz+l/iplO2vkqql/DVMQ=; h=From:To:Subject:Date:From; b=ISM/2jGWMLJwCcvs/4U9Q4s3MnTFxiVZYpPcVt4ZUHs9H9fApluRk5bIJ+Cvk/pIu ifrDTkGO2+xIf54IrGzah1KlWnKAXCOyaF43JjNp3Sa0trSDUAXJLlrpPSAEJnIfjk Kx4sXbWQqrB2FXrtHvXArWjsHspWS6hR68Wc0vcs= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] cindex: fix --join=reset and speed up incremental joins Date: Fri, 24 Nov 2023 09:53:46 +0000 Message-ID: <20231124095346.3935-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: `reset' means we want to ignore existing join data, while the default (non-reset) means we perform an incremental join while taking into account existing (fuzzy) join data. --- lib/PublicInbox/CodeSearchIdx.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm index 3a551c84..81ca5cbc 100644 --- a/lib/PublicInbox/CodeSearchIdx.pm +++ b/lib/PublicInbox/CodeSearchIdx.pm @@ -997,7 +997,7 @@ sub init_join_postfork ($) { require_progs('join', join => \@JOIN); my $d2 = '([0-9]{2})'; my $dt_re = qr!([0-9]{4})$d2$d2$d2$d2$d2!; - if (my $cur = $JOIN{reset} ? current_join_data($self) : undef) { + if (my $cur = $JOIN{reset} ? undef : current_join_data($self)) { if (($cur->{dt}->[1] // '') =~ m!\A$dt_re\z!o) { my ($Y, $m, $d, $H, $M, $S) = ($1, $2, $3, $4, $5, $6); my $t = timegm($S, $M, $H, $d, $m - 1, $Y);