[PATCH] cindex: fix test when missing time(1) executable

[Eric Wong <e@80x24.org>]

Eric Wong <e@80x24.org> wrote:
> +++ b/t/cindex.t
> @@ -210,7 +210,7 @@ EOM
>  	my $cmd = [ qw(-cindex -u --all --associate -d), "$tmp/ext",
>  		'-I', $basic->{inboxdir} ];
>  	$cidx_out = $cidx_err = '';
> -	ok(run_script($cmd, $env, $opt), 'associate w/o search');
> +	ok(run_script($cmd, $env, undef), 'associate w/o search');
>  	like($cidx_err, qr/W: \Q$basic->{inboxdir}\E not indexed for search/,
>  		'non-Xapian-enabled inbox noted');
>  }

Yeah, using this on your new VM showed the problem right away:

------8<------
Subject: [PATCH] cindex: fix test when missing time(1) executable

It was only there for development purposes because associate is
slow, but it causes the test to get stuck on systems where it's
not available.  So remove it and just call join(1posix).

Note: this is not the `time' builtin found in shells, this
executable shows memory and pagefault info (and more with the
`-v' switch).  Unfortunately, it's not installed on many systems
despite being widely-packaged.

Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
---
 lib/PublicInbox/CodeSearchIdx.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 9ceef16c..3a30b5e5 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -890,7 +890,7 @@ sub associate {
 	my @pending = keys %{$self->{PENDING}};
 	die "E: pending=@pending jobs not done\n" if @pending;
 	progress($self, 'associating...');
-	my @join = ('time', @JOIN, 'to_ibx_id', 'to_root_id');
+	my @join = (@JOIN, 'to_ibx_id', 'to_root_id');
 	my $rd = popen_rd(\@join, $CMD_ENV, { -C => "$TMPDIR" });
 	my %score;
 	while (<$rd>) { # PFX ibx_ids root_id


Much more gnarly work happening in this area :>