unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] cindex: fix test when missing time(1) executable
Date: Wed, 15 Nov 2023 08:25:53 -0500	[thread overview]
Message-ID: <20231115-almond-muskrat-from-hyperborea-b56abd@nitro> (raw)
In-Reply-To: <20231115055549.M979749@dcvr>

On Wed, Nov 15, 2023 at 05:55:49AM +0000, Eric Wong wrote:
> Eric Wong <e@80x24.org> wrote:
> > +++ b/t/cindex.t
> > @@ -210,7 +210,7 @@ EOM
> >  	my $cmd = [ qw(-cindex -u --all --associate -d), "$tmp/ext",
> >  		'-I', $basic->{inboxdir} ];
> >  	$cidx_out = $cidx_err = '';
> > -	ok(run_script($cmd, $env, $opt), 'associate w/o search');
> > +	ok(run_script($cmd, $env, undef), 'associate w/o search');
> >  	like($cidx_err, qr/W: \Q$basic->{inboxdir}\E not indexed for search/,
> >  		'non-Xapian-enabled inbox noted');
> >  }
> 
> Yeah, using this on your new VM showed the problem right away:

Yes, I can confirm that this hang is now gone. \o/
All the tests succeed now with the latest master.

Thanks, as always!

-K

      reply	other threads:[~2023-11-15 13:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 21:50 t/cindex.t "associate w/o search" test hangs for me Konstantin Ryabitsev
2023-11-14 22:16 ` Eric Wong
2023-11-14 22:30   ` Konstantin Ryabitsev
2023-11-14 22:46     ` Eric Wong
2023-11-14 23:05       ` Konstantin Ryabitsev
2023-11-14 23:46         ` Eric Wong
2023-11-14 23:51           ` Konstantin Ryabitsev
2023-11-15  0:07             ` Konstantin Ryabitsev
2023-11-15  1:06               ` Eric Wong
2023-11-15  1:43                 ` Konstantin Ryabitsev
2023-11-15  3:09                   ` Eric Wong
2023-11-15 13:21                     ` Konstantin Ryabitsev
2023-11-15 19:30                       ` Eric Wong
2023-11-25 20:43                         ` libgit2 [was: Re: t/cindex.t "associate w/o search" test hangs for me] Eric Wong
2023-11-15  1:11             ` t/cindex.t "associate w/o search" test hangs for me Eric Wong
2023-11-15  5:55           ` [PATCH] cindex: fix test when missing time(1) executable Eric Wong
2023-11-15 13:25             ` Konstantin Ryabitsev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115-almond-muskrat-from-hyperborea-b56abd@nitro \
    --to=konstantin@linuxfoundation.org \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).