From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 555831F87E for ; Thu, 9 Nov 2023 10:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1699524588; bh=PAnG9SPNgnyDQTL9TkBI9OnubhNEq+dyWw7E8ifWsAA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HwhbPOSv/IMYMJ8Vh4WtKyeGyltvLmAX+O9EvAjC9q4n1wYEJ/lwaAEZTXuB7fBGI KjnhfkjEGRnoZclSwSLJBpv20KEzce7Iw3Vb2HRIyanIzzb9xJdqZUcpeP26nr5VHp WBfap0Yuseo/JhxZwFTMdl6Jb8G1stKO9oJ0YrZ8= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/13] lei_mirror: note missing local manifests are non-fatal Date: Thu, 9 Nov 2023 10:09:41 +0000 Message-ID: <20231109100946.1440611-9-e@80x24.org> In-Reply-To: <20231109100946.1440611-1-e@80x24.org> References: <20231109100946.1440611-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Sometimes seeing that warning is alarming. --- lib/PublicInbox/LeiMirror.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 49febe9e..84266d03 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -950,10 +950,11 @@ sub load_current_manifest ($) { if (CORE::open(my $fh, '<', $fn)) { decode_manifest($fh, $fn, $fn); } elsif ($!{ENOENT}) { # non-fatal, we can just do it slowly - warn "open($fn): $!\n" if !$self->{-initial_clone}; + $self->{-initial_clone} or + warn "W: open($fn): $! (non-fatal)\n"; undef; } else { - die "open($fn): $!\n"; + die "E: open($fn): $!\n"; } }