From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 05/13] net_nntp_socks: more comments around how it works
Date: Thu, 9 Nov 2023 10:09:38 +0000 [thread overview]
Message-ID: <20231109100946.1440611-6-e@80x24.org> (raw)
In-Reply-To: <20231109100946.1440611-1-e@80x24.org>
This is convoluted as hell but I can't figure out a better way
to make Net::NNTP work with SOCKS.
---
lib/PublicInbox/NetNNTPSocks.pm | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/NetNNTPSocks.pm b/lib/PublicInbox/NetNNTPSocks.pm
index 5b15dd59..306dcacb 100644
--- a/lib/PublicInbox/NetNNTPSocks.pm
+++ b/lib/PublicInbox/NetNNTPSocks.pm
@@ -1,13 +1,13 @@
# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
-# wrap Net::NNTP client with SOCKS support
+# wrap Net::NNTP client with SOCKS support. Convoluted, but AFAIK this
+# is the only way to get SOCKS working with Net::NNTP w/o LD_PRELOAD.
package PublicInbox::NetNNTPSocks;
use v5.12;
use Net::NNTP;
-our %OPT;
+our %OPT; # used to pass options between ->new_socks and our ->new
our @ISA = qw(IO::Socket::Socks);
-my @SOCKS_KEYS = qw(ProxyAddr ProxyPort SocksVersion SocksDebug SocksResolve);
# use this instead of Net::NNTP->new if using Proxy*
sub new_socks {
@@ -16,9 +16,10 @@ sub new_socks {
local @Net::NNTP::ISA = (qw(Net::Cmd), __PACKAGE__);
local %OPT = map {;
defined($opt{$_}) ? ($_ => $opt{$_}) : ()
- } @SOCKS_KEYS;
+ } qw(ProxyAddr ProxyPort SocksVersion SocksDebug SocksResolve);
no warnings 'uninitialized'; # needed for $SOCKS_ERROR
- Net::NNTP->new(%opt) // die "errors: \$!=$! SOCKS=",
+ my $ret = Net::NNTP->new(%opt); # calls PublicInbox::NetNNTPSocks::new
+ $ret // die "errors: \$!=$! SOCKS=",
eval('$IO::Socket::Socks::SOCKS_ERROR // ""'),
', SSL=',
(eval('IO::Socket::SSL->errstr') // ''), "\n";
next prev parent reply other threads:[~2023-11-09 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 10:09 [PATCH 00/13] misc error handling stuff and simplifications Eric Wong
2023-11-09 10:09 ` [PATCH 01/13] lei_xsearch: put query in process title for debugging Eric Wong
2023-11-09 10:09 ` [PATCH 02/13] lei: use cached $daemon_pid when possible Eric Wong
2023-11-09 10:09 ` [PATCH 03/13] lei: reuse FDs atfork and close explicitly Eric Wong
2023-11-09 10:09 ` [PATCH 04/13] lei_up: use v5.12 Eric Wong
2023-11-09 10:09 ` Eric Wong [this message]
2023-11-09 10:09 ` [PATCH 06/13] lei ls-mail-source: gracefully handle network failures Eric Wong
2023-11-09 10:09 ` [PATCH 07/13] net: retry on EINTR and check for {quit} flag Eric Wong
2023-11-09 10:09 ` [PATCH 08/13] lei_mirror: note missing local manifests are non-fatal Eric Wong
2023-11-09 10:09 ` [PATCH 09/13] ipc: simplify partial sendmsg fallback Eric Wong
2023-11-09 10:09 ` [PATCH 10/13] lei_input: always close single `eml' inputs Eric Wong
2023-11-09 10:09 ` [PATCH 11/13] xapcmd: get rid of scalar wantarray popen_rd Eric Wong
2023-11-09 10:09 ` [PATCH 12/13] lei: get rid of autoreap usage Eric Wong
2023-11-09 10:09 ` [PATCH 13/13] spawn: get rid of wantarray popen_rd/popen_wr Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109100946.1440611-6-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).