From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CA1851FA54 for ; Wed, 25 Oct 2023 00:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1698193792; bh=fpoUGUCRF1CznBQeQ+ZuJMEo1E+07Ew2PE7xwxC8Vxs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=q8QdUz2lgQ8Ff1IZjF1+OmXks2XY5VcwDE5y7JlTu5PvTQcXofVjAhzJHKSdgP6z5 n3vvHRXqTfnxuauc+GtJlyK/HX/N3VHtGhbXOSTIMKlpiuLn/NSfak7SEEY4VFeNXV 5+cPCpnng3bPCwOQ57jsoLrXreCkbfS/9k09NrvQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 19/26] cidx_log_p: don't bother with F_SETPIPE_SZ Date: Wed, 25 Oct 2023 00:29:42 +0000 Message-ID: <20231025002949.3092193-20-e@80x24.org> In-Reply-To: <20231025002949.3092193-1-e@80x24.org> References: <20231025002949.3092193-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It doesn't help here since the bottleneck is Xapian indexing (and not `git log -p'). This fcntl call was also in the way of switching to ProcessIO. --- lib/PublicInbox/CidxLogP.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/PublicInbox/CidxLogP.pm b/lib/PublicInbox/CidxLogP.pm index 34f7201d..ac4c1b37 100644 --- a/lib/PublicInbox/CidxLogP.pm +++ b/lib/PublicInbox/CidxLogP.pm @@ -10,12 +10,11 @@ package PublicInbox::CidxLogP; use v5.12; use parent qw(PublicInbox::DS); -use PublicInbox::Syscall qw(EPOLLIN EPOLLONESHOT $F_SETPIPE_SZ); +use PublicInbox::Syscall qw(EPOLLIN EPOLLONESHOT); sub new { my ($cls, $rd, $cidx, $git, $roots) = @_; my $self = bless { cidx => $cidx, git => $git, roots => $roots }, $cls; - fcntl($rd, $F_SETPIPE_SZ, 1048576) if $F_SETPIPE_SZ; $self->SUPER::new($rd, EPOLLIN|EPOLLONESHOT); }