From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 610C31F677 for ; Tue, 17 Oct 2023 23:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1697585897; bh=E82loDZD5RF83ErxQS5zfTtnNvnUMPizrURQoef8Q2U=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RCVuM7r1QOo/0UEnkPrCcTVrL3nGcsE9AqtJb/T7bhhqRHXj5KET0m9KsZZKLhDxA 9KaO6FpOnZgr/u1sw2wa5KdNnk4mK4VeqXI2AvVm1CXGS8+BsUjM89UP8z/uO7OXo+ XUBGAg8a0Cc/lmjxRhYCapPNME7TwJ69aAJeJjqI= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/30] xap_helper*: use autodie in more places Date: Tue, 17 Oct 2023 23:37:53 +0000 Message-ID: <20231017233815.1637932-9-e@80x24.org> In-Reply-To: <20231017233815.1637932-1-e@80x24.org> References: <20231017233815.1637932-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This ought to lower the cognitive overhead of reading our code. --- lib/PublicInbox/XapHelperCxx.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/XapHelperCxx.pm b/lib/PublicInbox/XapHelperCxx.pm index 83015379..bd616b6f 100644 --- a/lib/PublicInbox/XapHelperCxx.pm +++ b/lib/PublicInbox/XapHelperCxx.pm @@ -29,12 +29,13 @@ my $xflags = ($ENV{CXXFLAGS} // '-Wall -ggdb3 -O0') . ' ' . my $xap_modversion; sub xap_cfg (@) { - open my $err, '+>', undef or die "open(undef): $!"; + use autodie qw(open seek); + open my $err, '+>', undef; my $cmd = [ $ENV{PKG_CONFIG} // 'pkg-config', @_, 'xapian-core' ]; my $rd = popen_rd($cmd, undef, { 2 => $err }); chomp(my $ret = do { local $/; <$rd> }); return $ret if close($rd); - seek($err, 0, SEEK_SET) or die "seek: $!"; + seek($err, 0, SEEK_SET); $err = read_all($err); die <