From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 1CB471F724
	for <meta@public-inbox.org>; Tue, 17 Oct 2023 23:38:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1697585898;
	bh=wKo6dJxbzzRMwC7OW3yPQLCuFDLBuPUHq8ybwopplNU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=fhS+qeC1OSfcPg6zvUPebdWiIqPyLp57y5EWc5OCC7NboqqWPMwFqhKpyuk9iPM5p
	 TuLzdCisdcbQdq9O8hAzfwNAevg6TD0YcHxHzxiIpJQ2ae2yKpxSrBOP05qukZFMqF
	 9dNjdXt994q+A+lGHB4N2nJIdx5nuBLOZNlFbpAU=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 12/30] xap_client: autodie for pipe and socketpair
Date: Tue, 17 Oct 2023 23:37:57 +0000
Message-ID: <20231017233815.1637932-13-e@80x24.org>
In-Reply-To: <20231017233815.1637932-1-e@80x24.org>
References: <20231017233815.1637932-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

This saves us a few lines of code.
---
 lib/PublicInbox/XapClient.pm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/lib/PublicInbox/XapClient.pm b/lib/PublicInbox/XapClient.pm
index 9e2d71a0..21c89265 100644
--- a/lib/PublicInbox/XapClient.pm
+++ b/lib/PublicInbox/XapClient.pm
@@ -11,14 +11,12 @@ use v5.12;
 use PublicInbox::Spawn qw(spawn);
 use Socket qw(AF_UNIX SOCK_SEQPACKET);
 use PublicInbox::IPC;
+use autodie qw(pipe socketpair);
 
 sub mkreq {
 	my ($self, $ios, @arg) = @_;
-	my ($r, $w, $n);
-	if (!defined($ios->[0])) {
-		pipe($r, $w) or die "pipe: $!";
-		$ios->[0] = $w;
-	}
+	my ($r, $n);
+	pipe($r, $ios->[0]) if !defined($ios->[0]);
 	my @fds = map fileno($_), @$ios;
 	my $buf = join("\0", @arg, '');
 	$n = $PublicInbox::IPC::send_cmd->($self->{io}, \@fds, $buf, 0) //
@@ -29,8 +27,7 @@ sub mkreq {
 
 sub start_helper {
 	my @argv = @_;
-	socketpair(my $sock, my $in, AF_UNIX, SOCK_SEQPACKET, 0) or
-		die "socketpair: $!";
+	socketpair(my $sock, my $in, AF_UNIX, SOCK_SEQPACKET, 0);
 	my $cls = ($ENV{PI_NO_CXX} ? undef : eval {
 			require PublicInbox::XapHelperCxx;
 			PublicInbox::XapHelperCxx::check_build();