From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B1DE81F47D for ; Sat, 7 Oct 2023 21:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1696713850; bh=3bcS57cQ9HMMI2UPwTDAxqxcki4/HhD1jiSuLbThgD8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=5X0PcxnWVl3D6sLnGxDL5ep2HHK3SaUCIoYFWQSe0Uu9p+kpKwGXXmI52XsmAbJ1S 70iDnlUdZRpPbzhQGSxYAo1ds60OG70UKm6J1FDdCWPNE9ssbB3HgXP3kfsfXrlEt+ iWYxHxpR+X8yGXbAhDcBaofHh8qBpWrPxJtx+fzU= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/9] lei: do not issue sto->done if socket is inactive Date: Sat, 7 Oct 2023 21:24:03 +0000 Message-ID: <20231007212410.297785-3-e@80x24.org> In-Reply-To: <20231007212410.297785-1-e@80x24.org> References: <20231007212410.297785-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This fixes attempts to use an undefined value as an ARRAY reference in PublicInbox::IPC::wq_io_do --- lib/PublicInbox/LEI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index f8bcd43d..f00b2465 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -1296,7 +1296,7 @@ sub can_stay_alive { # PublicInbox::DS::post_loop_do cb my $lne = delete($cfg->{-lei_note_event}); $lne->wq_close if $lne; my $sto = delete($cfg->{-lei_store}) // next; - eval { $sto->wq_io_do('done') }; + eval { $sto->wq_do('done') if $sto->{-wq_s1} }; warn "E: $@ (dropping store for $cfg->{-f})" if $@; $sto->wq_close; }