From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] ipc: lower-level send_cmd/recv_cmd handle EINTR directly
Date: Fri, 6 Oct 2023 09:38:02 +0000 [thread overview]
Message-ID: <20231006093802.M634465@dcvr> (raw)
In-Reply-To: <20231006013713.3762219-1-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> --- a/t/xap_helper.t
> +++ b/t/xap_helper.t
> @@ -52,8 +52,8 @@ my $doreq = sub {
> my $buf = join("\0", @arg, '');
> my @fds = fileno($y);
> push @fds, fileno($err) if $err;
> - my $n = PublicInbox::IPC::send_cmd($s, \@fds, $buf, 0);
> - $n // xbail "send: $!";
> + my $n = $PublicInbox::IPC::send_cmd->($s, \@fds, $buf, 0) //
> + xbail "send: $!";
Erm, needs this to quiet a warning:
diff --git a/t/xap_helper.t b/t/xap_helper.t
index 27742cad..7890392d 100644
--- a/t/xap_helper.t
+++ b/t/xap_helper.t
@@ -7,7 +7,7 @@ require_mods(qw(DBD::SQLite Xapian +SCM_RIGHTS)); # TODO: FIFO support?
use PublicInbox::Spawn qw(spawn);
use Socket qw(AF_UNIX SOCK_SEQPACKET SOCK_STREAM);
require PublicInbox::AutoReap;
-require PublicInbox::IPC;
+use PublicInbox::IPC;
require PublicInbox::XapClient;
use autodie;
my ($tmp, $for_destroy) = tmpdir();
Will squash.
prev parent reply other threads:[~2023-10-06 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 1:37 [PATCH] ipc: lower-level send_cmd/recv_cmd handle EINTR directly Eric Wong
2023-10-06 9:38 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006093802.M634465@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).