From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5B8FD1F578 for ; Wed, 4 Oct 2023 03:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1696391376; bh=MLuep84/PM72gkC/vk3VMCzID2sVOlszuU+yw0LMULk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=bo6jJtfHA/dx2Zc36F3cO0RxAQWc4hNruHEH04uZAbU97cZHNmRczXICy7UITDRyM pSpfK6G1mdi5pw4ODpqTkWs8AJEJt1M8IyEzKm1efTKWH/EoNh2wuSMWkAnwiOhWO7 HXaGZfZS7QHZ6ktnr5TL6A5ozhoeHisNtp3JLhYo= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 18/21] xap_helper.pm: use EINTR-aware recv_cmd Date: Wed, 4 Oct 2023 03:49:30 +0000 Message-ID: <20231004034933.3343930-19-e@80x24.org> In-Reply-To: <20231004034933.3343930-1-e@80x24.org> References: <20231004034933.3343930-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The code is already loaded, so there's no point in avoiding it. --- lib/PublicInbox/XapHelper.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/XapHelper.pm b/lib/PublicInbox/XapHelper.pm index f90b283d..c98708e3 100644 --- a/lib/PublicInbox/XapHelper.pm +++ b/lib/PublicInbox/XapHelper.pm @@ -177,12 +177,9 @@ sub recv_loop { my $in = \*STDIN; while (!defined($parent_pid) || getppid == $parent_pid) { PublicInbox::DS::sig_setmask($workerset); - my @fds = $PublicInbox::IPC::recv_cmd->($in, $rbuf, 4096*33); + my @fds = PublicInbox::IPC::recv_cmd($in, $rbuf, 4096*33); scalar(@fds) or exit(66); # EX_NOINPUT - if (!defined($fds[0])) { - next if $!{EINTR}; - die "recvmsg: $!"; - } + die "recvmsg: $!" if !defined($fds[0]); PublicInbox::DS::block_signals(); my $req = bless {}, __PACKAGE__; my $i = 0;