From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0844A1F56D for ; Wed, 4 Oct 2023 03:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1696391375; bh=ywjLQH1363ye1WtmGgyhJFhVjrz+wLtsU3MLjHAxJ5o=; h=From:To:Subject:Date:In-Reply-To:References:From; b=4mvLNQqqEfuivv7HdSENPpCtpXfeJ/WV1cIpwYORxMcniIvrt3EJHsb4mS7u4kaLL vxth8P/7PxeulkkrxkITHRt7kadP2fMo2hxp/rvqE0sizAsfIK70uSiLhDoBSJLjCW KWfqWXgcpMHAkIfRnpdoyK+HIQCPJv8quiMZYOi0= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 10/21] lei: reuse PublicInbox::Config::noop Date: Wed, 4 Oct 2023 03:49:22 +0000 Message-ID: <20231004034933.3343930-11-e@80x24.org> In-Reply-To: <20231004034933.3343930-1-e@80x24.org> References: <20231004034933.3343930-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No need to define our own empty `noop' sub when PublicInbox::Config already has one and is loaded anyways. --- lib/PublicInbox/LEI.pm | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index fba4edf3..c9ad46e2 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -1217,8 +1217,6 @@ sub event_step_init { }; } -sub noop {} - sub oldset { $oldset } sub dump_and_clear_log { @@ -1364,15 +1362,9 @@ sub lazy_start { $lis->close; # DS::close }; }; - my $sig = { - CHLD => \&PublicInbox::DS::enqueue_reap, - QUIT => $quit, - INT => $quit, - TERM => $quit, - HUP => \&noop, - USR1 => \&noop, - USR2 => \&noop, - }; + my $sig = { CHLD => \&PublicInbox::DS::enqueue_reap }; + $sig->{$_} = $quit for qw(QUIT INT TERM); + $sig->{$_} = \&PublicInbox::Config::noop for qw(HUP USR1 USR2); # for EVFILT_SIGNAL and signalfd behavioral difference: my @kq_ign = eval { require PublicInbox::DSKQXS } ? keys(%$sig) : ();