From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 2023C1F55F;
	Thu, 21 Sep 2023 10:23:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1695291791;
	bh=0ENbEDmhrj4mEt+Q+HVEyv/jJm4Gnc/OfIit905sks0=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=ZmBBP2Gh96JnwfOvBcjkafHvBeNZTM1y633PI4U8oE0oTU88FWXZv4aNieArpeppC
	 dUe1bt3lzDwrxyJkW4rbFJpP8DalBg1FRHz/Ez8H6U/NwGEbaqSA5BdcSyDvv1QU1T
	 sUsxipwCQz1VhTkAXEnTv9S9qEa1ckO3H2IQnAlM=
Date: Thu, 21 Sep 2023 10:23:10 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 03/15] t/lei-p2q: extra diagnostics
Message-ID: <20230921102311.M27557@dcvr>
References: <20211021211032.22666-1-e@80x24.org>
 <20211021211032.22666-4-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211021211032.22666-4-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> I got one mysterious test failure here, once, and can't seem
> to reproduce it...

nearly 2 years later: I've hit it again, but once again cannot
reproduce it...

> +++ b/t/lei-p2q.t
> @@ -7,7 +7,7 @@ require_mods(qw(json DBD::SQLite Search::Xapian));
>  
>  test_lei(sub {
>  	ok(!lei(qw(p2q this-better-cause-format-patch-to-fail)),
> -		'p2q fails on bogus arg');
> +		'p2q fails on bogus arg') or diag $lei_err;
>  	like($lei_err, qr/format-patch.*failed/, 'notes format-patch failure');

$? does get printed (32768, so (>> 8) means 128), as it should be.
So I wonder if there's a place we drop the socket prematurely or
something else is amiss...

On a side note, lei's internal IPC could probably be simplified
a bit w/o sacrificing parallelism.