From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/8] makefile: avoid needless use of double-colon rules
Date: Mon, 18 Sep 2023 10:15:13 +0000 [thread overview]
Message-ID: <20230918101516.2477899-6-e@80x24.org> (raw)
In-Reply-To: <20230918101516.2477899-1-e@80x24.org>
This non-portable construct isn't needed for our own rules.
I'm understanding them correctly, they have different
semantics between *BSDs and GNU make.
---
Documentation/include.mk | 8 ++++----
Makefile.PL | 14 +++++++-------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk
index 4395e4f4..eb65454a 100644
--- a/Documentation/include.mk
+++ b/Documentation/include.mk
@@ -47,14 +47,14 @@ install-man: man
doc_install :: install-man
-check :: check-man
+check : check-man
check_man = $(AWK) \
'{gsub(/\b./,"")}$$0 !~ /\.onion/&&length>80{print;e=1}END{exit(e)}' \
>&2
-check-man :: $(check_80)
+check-man : $(check_80)
-check-lexgrog :: $(check_lexgrog)
+check-lexgrog : $(check_lexgrog)
all :: $(docs)
@@ -86,7 +86,7 @@ NEWS NEWS.atom NEWS.html : $(news_deps)
$(PERL) -I lib -w Documentation/mknews.perl $@ $(RELEASES)
# check for internal API changes:
-check :: NEWS .NEWS.atom.check NEWS.html
+check : NEWS .NEWS.atom.check NEWS.html
.NEWS.atom.check: NEWS.atom
$(XMLSTARLET) val NEWS.atom || \
diff --git a/Makefile.PL b/Makefile.PL
index 9dc18b5c..81992e46 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -213,7 +213,7 @@ $VARS
-include Documentation/include.mk
$TGTS
-check-man :: $check_lexgrog$warn_no_pod
+check-man : $check_lexgrog$warn_no_pod
# syntax checks are currently GNU make only:
%.syntax :: %
@@ -231,24 +231,24 @@ check-manifest : MANIFEST
\$(check_manifest)
# the traditional way running per-*.t processes:
-check-each :: pure_all
+check-each : pure_all
\$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N)
-@\$(check_manifest)
# check-run relies "--state=save" in check-each for best performance
-check-run :: check-man
+check-run : check-man
# n.b. while `-' isn't specified as an allowed make(1posix) macro name,
# GNU and *BSD both allow it.
check-run_T_ARGS = -j\$(N)
-check-debris check-run :: pure_all
+check-debris check-run : pure_all
\$(EATMYDATA) \$(PROVE) -bvw xt/\$@.t :: \$(\$\@_T_ARGS)
-@\$(check_manifest)
-check :: check-each
+check : check-each
-lib/PublicInbox/UserContent.pm :: contrib/css/216dark.css
+lib/PublicInbox/UserContent.pm : contrib/css/216dark.css
\$(PERL) -I lib \$@ \$?
# Ensure new .pm files will always be installed by updating
@@ -269,7 +269,7 @@ symlink-install : lib/PublicInbox.pm
ln -sf "\$\$lei" \$\$(basename "\$\$x"); \\
done
-pure_all :: lib/PublicInbox.pm
+pm_to_blib : lib/PublicInbox.pm
lib/PublicInbox.pm : FORCE
VERSION=\$(VERSION) \$(PERL) -w ./version-gen.perl
next prev parent reply other threads:[~2023-09-18 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 10:15 [PATCH 0/8] portability odds and ends Eric Wong
2023-09-18 10:15 ` [PATCH 1/8] ci/run: favor `make check' as the default target Eric Wong
2023-09-18 10:15 ` [PATCH 2/8] drop GNU nproc(1) support in favor of getconf(1) Eric Wong
2023-09-18 10:15 ` [PATCH 3/8] ipc: assume SOCK_SEQPACKET exists Eric Wong
2023-09-18 10:15 ` [PATCH 4/8] rename t/run.perl to xt/check-run Eric Wong
2023-09-18 10:15 ` Eric Wong [this message]
2023-09-18 10:15 ` [PATCH 6/8] pop3d: split @FLOCK into $FLOCK_TMPL and @FLOCK_ORDER Eric Wong
2023-09-18 10:15 ` [PATCH 7/8] install/deps: more fixes Eric Wong
2023-09-18 10:15 ` [PATCH 8/8] makefile: avoid non-POSIX which(1) Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918101516.2477899-6-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).