From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id DB1DF1F55F
	for <meta@public-inbox.org>; Tue, 12 Sep 2023 02:34:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1694486042;
	bh=C4CC2bks9WJ3eVjlEXNRG6GbylZduReiYdqDS1ohbbA=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=ktZozLsROh0hp47wudWluPKULNDVShpASqTJKHqhNOoZqpyuBwwsWI2cIBN3Tlp0i
	 09VbR4ZRtO1zLhh7Eh9fE2caoSgKjS+g74F1mmhsFDv7SK7g3GKSJ8LATs+pvrqXRU
	 yoJhitMOSWTGpuyhm2gh7QiQoizsLrvY6YuWGtak=
Date: Tue, 12 Sep 2023 02:34:02 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 5/7] dspoll: switch to the documented IO::Poll API
Message-ID: <20230912023402.M761405@dcvr>
References: <20230911094132.75792-1-e@80x24.org>
 <20230911094132.75792-6-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230911094132.75792-6-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> So switch to the documented API and just learn to live with some
> redundant object references and awkwardness in the API.

Unfortunately, this introduces unintended consequences with
object destruction order and some explicit calls to DS->Reset
(and modifications to destruction order) becomes necessary.

I noticed this testing t/gcf2_client.t (and also realized
libgit2 isn't in the CI deps, gotta add that along with
a few other tweaks brewing...)

So I guess we'll just have to keep an eye on IO::Poll::_poll
changes or replace it with select(2) since it should all
be low-numbered FDs anyways.