From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from mail.smrk.net (mail.smrk.net [IPv6:2001:19f0:6c01:2788:5400:4ff:fe27:adaa]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8BB571F560 for ; Sat, 2 Sep 2023 10:54:54 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=smrk.net header.i=@smrk.net header.a=rsa-sha256 header.s=20221002 header.b=g66RXXf/; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smrk.net; s=20221002; t=1693652090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2o25NKhq0uBIdAOlQWk4SzEzLMW6Blln8YXS6+KeLUc=; b=g66RXXf/yAwavoo8LvBRdiXsCP+XQcElINbZXiLj0Ub72tGc2MisraHxpjh1OVIvab3U7A iTounOwKN8hX5jIf18gvI448ytU3HmALCmNE5S9WEEaZOpBNfA0wJfMCuZXvkBJq4dm3Wd crDm8eKe3yUOjwFwjitTl8zrJdMwu7RsKn0yJUAaw7MTfmG9IajOgtTfpbedxcI5pf+3QO f5+y2qfOGg8KSpArjAnbDKmaLlSEaCpIVakdhGbFLCBcFIL1JE/BVB7Pjpt+OMqfDn79CD bos7IaEFtX/m+gSZl8wSkoaBCBbqGh6wokCV3kYK8ngrcRQ59xJrZLhrRlYFAw== Received: from localhost ( [192.168.5.2]) by smrk (OpenSMTPD) with ESMTPSA id 8ad26995 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 2 Sep 2023 12:54:50 +0200 (CEST) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH 0/7] various build fixes + OpenBSD compat, [PATCH 7/7] xap_helper.h: fix double-free on OpenBSD hdestroy In-Reply-To: <20230901110903.M876537@dcvr> References: <20230830051045.330641-1-e@80x24.org> <20230830051045.330641-1-e@80x24.org> <20230830143409+0200.929541-stepnem@smrk.net> <20230830211849.M275594@dcvr> <20230831111152+0200.360729-stepnem@smrk.net> <20230831192650+0200.929387-stepnem@smrk.net> <20230901110903.M876537@dcvr> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/30.0.50 (x86_64-pc-linux-gnu) Date: Sat, 02 Sep 2023 12:54:49 +0200 Message-ID: <20230902125449+0200.22309-stepnem@smrk.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: On Fri, 01 Sep 2023 11:09:03 +0000 Eric Wong wrote: > =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec wrote: >> Ah, I see now that PERFORMANCE NOTES in lei-overview.pod says Inline::C >> is required, so perhaps just some adjustments to the test >> skipping/diagnostics and INSTALL instructions (which say Inline::C is >> optional) would be helpful? > > Actually, Inline::C is only needed for lei on *BSDs nowadays. > Common/available-on-cfarm Linux arches can rely on stable > syscall numbers to do FD passing. I see, thanks. How about this then: -- >8 -- Subject: [PATCH] Clarify Inline::C dependency (optional on Linux, required elsewhere) Link: https://public-inbox.org/meta/20230901110903.M876537@dcvr/ Fixes: 88c7c7c26b44 ("lei: wire up pure Perl sendmsg/recvmsg for Linux user= s") Fixes: acefd91b302d ("syscall: implement sendmsg+recvmsg in pure Perl") --- Documentation/lei-overview.pod | 12 +++++++----- INSTALL | 7 ++++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/Documentation/lei-overview.pod b/Documentation/lei-overview.pod index 7095b504cdb8..e9a97d64fb56 100644 --- a/Documentation/lei-overview.pod +++ b/Documentation/lei-overview.pod @@ -119,11 +119,13 @@ code repository. =20 =3Dhead1 PERFORMANCE NOTES =20 -L is required, lei runs as a background daemon to reduce -startup costs and can provide real-time L/L -Maildir monitoring. L (p5-IO-KQueue on FreeBSD) and -L (liblinux-inotify2-perl and perl-Linux-Inotify2 in -.deb and .rpm-based distros, respectively) are recommended. +L is required on BSDs and can speed things up on Linux. + +lei runs as a background daemon to reduce startup costs and can +provide real-time L/L Maildir monitoring. +L (p5-IO-KQueue on FreeBSD) and L +(liblinux-inotify2-perl and perl-Linux-Inotify2 in .deb and .rpm-based +distros, respectively) are recommended. =20 L is optional (libsocket-msghdr-perl in Debian), and further improves startup performance. Its effect is most felt diff --git a/INSTALL b/INSTALL index 5f080f2889ce..e8d686d8f21b 100644 --- a/INSTALL +++ b/INSTALL @@ -60,7 +60,7 @@ Where "deb" indicates package names for Debian-derived di= stributions, "pkg" is for the FreeBSD package (maybe other common BSDs, too), and "rpm" is for RPM-based distributions (only known to work on Fedora). =20 -Numerous optional modules are likely to be useful as well: +Numerous other modules are likely to be useful as well: =20 - DBD::SQLite deb: libdbd-sqlite3-perl pkg: p5-DBD-SQLite @@ -76,8 +76,9 @@ Numerous optional modules are likely to be useful as well: - Inline::C deb: libinline-c-perl pkg: p5-Inline-C rpm: perl-Inline (or perl-Inline-C) - (speeds up process spawning on Linux, - see public-inbox-daemon(8)) + (required for lei on *BSD; speeds up pr= ocess + spawning on Linux, see + public-inbox-daemon(8)) =20 - Email::Address::XS deb: libemail-address-xs-perl pkg: p5-Email-Address-XS --=20 2.42.0