From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id BB7251F406;
	Mon, 28 Aug 2023 21:19:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1693257596;
	bh=zscmrqXuz5/V2UIHW0S9WFuklMwj8hA0LHGV3gB9Fss=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=drGWXnOFStDy6I0C4r8Cx6AlM7lUou54AoK99tc1Yv/NOpQvLBqfaX+Y2uiiMVbfk
	 zEiu4OOa3U80sg30PKs6MbMJC8Lw3foxtHPYfAWZ2jRT6yEXxfQNAIadJA++0f3YZw
	 h/iLpbnijvgyntphdueKl5YCbjGFPN9QPe+xKobk=
Date: Mon, 28 Aug 2023 21:19:56 +0000
From: Eric Wong <e@80x24.org>
To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= <stepnem@smrk.net>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 1/2] t/init.t: test newly created config permissions
Message-ID: <20230828211956.M602074@dcvr>
References: <20230828104514.937030-1-stepnem@smrk.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230828104514.937030-1-stepnem@smrk.net>
List-Id: <meta.public-inbox.org>

Štěpán Němec <stepnem@smrk.net> wrote:
> Creating config 0600 disregarding umask breaks scenarios where daemons
> run with credentials different from config owner (but need to read the
> config).

Thanks for noticing.

> Fixed in the next commit.

I strongly prefer tests and fixes to be in the same commit to
simplify `git bisect' usage.  If you really prefer multiple
commits, I think the `TODO' directive of Test::More can help
preserve easy bisectability.  I haven't tried it myself, but I
just confirmed the Test::More man page on CentOS 7.x documents
it.

Can you either resubmit or let me know if you want me to squash
them together on my end?  Thanks again.