From: Eric Wong <e@80x24.org>
To: "Štěpán Němec" <stepnem@smrk.net>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 1/2] t/init.t: test newly created config permissions
Date: Mon, 28 Aug 2023 21:19:56 +0000 [thread overview]
Message-ID: <20230828211956.M602074@dcvr> (raw)
In-Reply-To: <20230828104514.937030-1-stepnem@smrk.net>
Štěpán Němec <stepnem@smrk.net> wrote:
> Creating config 0600 disregarding umask breaks scenarios where daemons
> run with credentials different from config owner (but need to read the
> config).
Thanks for noticing.
> Fixed in the next commit.
I strongly prefer tests and fixes to be in the same commit to
simplify `git bisect' usage. If you really prefer multiple
commits, I think the `TODO' directive of Test::More can help
preserve easy bisectability. I haven't tried it myself, but I
just confirmed the Test::More man page on CentOS 7.x documents
it.
Can you either resubmit or let me know if you want me to squash
them together on my end? Thanks again.
next prev parent reply other threads:[~2023-08-28 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 10:45 [PATCH 1/2] t/init.t: test newly created config permissions Štěpán Němec
2023-08-28 10:45 ` [PATCH 2/2] public-inbox-init: honor umask when creating config file Štěpán Němec
2023-08-28 21:19 ` Eric Wong [this message]
2023-08-28 21:30 ` [PATCH 1/2] t/init.t: test newly created config permissions Štěpán Němec
2023-08-29 1:13 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828211956.M602074@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
--cc=stepnem@smrk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).