From: "Štěpán Němec" <stepnem@smrk.net>
To: meta@public-inbox.org
Subject: [PATCH 3/5] spawn: remove stray variable $ndc_err
Date: Mon, 28 Aug 2023 12:42:44 +0200 [thread overview]
Message-ID: <20230828104246.936281-3-stepnem@smrk.net> (raw)
In-Reply-To: <20230828104246.936281-1-stepnem@smrk.net>
Code that could be setting it was removed in 14fa0abdcc7b.
Likewise for the double assignment to $err.
Fixes: 14fa0abdcc7b ("rewrite Linux nodatacow use in pure Perl w/o system")
---
lib/PublicInbox/Spawn.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 878843a60a8d..6e33c712d8d2 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -293,15 +293,12 @@ ALL_LIBC
use Inline C => $all_libc, BUILD_NOISY => 1;
EOM
my $err = $@;
- my $ndc_err = '';
- $err = $@;
open(STDERR, '>&', $olderr) or warn "restore stderr: $!";
open(STDOUT, '>&', $oldout) or warn "restore stdout: $!";
if ($err) {
seek($fh, 0, SEEK_SET);
my @msg = <$fh>;
- warn "Inline::C build failed:\n",
- $ndc_err, $err, "\n", @msg;
+ warn "Inline::C build failed:\n", $err, "\n", @msg;
$all_libc = undef;
}
}
--
2.42.0
next prev parent reply other threads:[~2023-08-28 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 10:42 [PATCH 1/5] ci/profiles.sh: fix case matching logic Štěpán Němec
2023-08-28 10:42 ` [PATCH 2/5] watch: remove unused variable Štěpán Němec
2023-08-28 10:42 ` Štěpán Němec [this message]
2023-08-28 10:42 ` [PATCH 4/5] spawn: remove distracting empty line Štěpán Němec
2023-08-28 10:42 ` [PATCH 5/5] Fix some typos/grammar/errors in docs and comments Štěpán Němec
2023-08-28 21:11 ` Eric Wong
2023-08-28 21:22 ` Štěpán Němec
2023-08-28 21:38 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828104246.936281-3-stepnem@smrk.net \
--to=stepnem@smrk.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).